Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 )
Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62466/comment/c80678ab_2f9b1804
PS3, Line 66: register "power_limits_config[ADL_P_282_482_28W_CORE]" = "{
Do we still need this? you already update the cpu_power_limits limits. […]
Probably still a good idea to have a known-good default in there in case of DPTF software errors.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82e2dbacd6cbc39390eb28f27ca9db48d6c215c
Gerrit-Change-Number: 62466
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 00:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment