Puthikorn Voravootivat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33180
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
mb/google/poppy/variants/atlas: Update DPTF parameter
The temperature delta between on-board thermistor and surface temp change, so update DPTF parameter accordingly.
BUG=b:113101335 TEST=Tested in thermal chamber by thermal team. See comment 144 / 146 in the bug.
Change-Id: Ie18be94fc1e7476755fb0e6947cce559854a82dd Signed-off-by: Puthikorn Voravootivat puthik@chromium.org --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/33180/1
diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl index 570fbbb..d8b6137 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl @@ -29,12 +29,12 @@
#define DPTF_TSR2_SENSOR_ID 3 #define DPTF_TSR2_SENSOR_NAME "DRAM" -#define DPTF_TSR2_PASSIVE 55 +#define DPTF_TSR2_PASSIVE 53 #define DPTF_TSR2_CRITICAL 75
#define DPTF_TSR3_SENSOR_ID 4 #define DPTF_TSR3_SENSOR_NAME "eMMC" -#define DPTF_TSR3_PASSIVE 52 +#define DPTF_TSR3_PASSIVE 51 #define DPTF_TSR3_CRITICAL 75
#undef DPTF_ENABLE_FAN_CONTROL
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 1: Code-Review+2
Puthikorn Voravootivat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 1: Code-Review-1
Thermal team found that we need to tune this a bit more
Furquan Shaikh has removed a vote on this change.
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Removed Code-Review+2 by Furquan Shaikh furquan@google.com
Hello caveh jalali, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33180
to look at the new patch set (#2).
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
mb/google/poppy/variants/atlas: Update DPTF parameter
The temperature delta between on-board thermistor and surface temp change, so update DPTF parameter accordingly.
BUG=b:113101335 TEST=Tested in thermal chamber by thermal team. See comment 148 / 153 in the bug.
Change-Id: Ie18be94fc1e7476755fb0e6947cce559854a82dd Signed-off-by: Puthikorn Voravootivat puthik@chromium.org --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/33180/2
Puthikorn Voravootivat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 2:
This is update to correct value now.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 2: Code-Review+2
Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 2: Code-Review+1
Puthikorn Voravootivat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
Patch Set 2:
Caveh / Furquan
Can you help merge this? So that we can cherry-pick to CrOS tree
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33180 )
Change subject: mb/google/poppy/variants/atlas: Update DPTF parameter ......................................................................
mb/google/poppy/variants/atlas: Update DPTF parameter
The temperature delta between on-board thermistor and surface temp change, so update DPTF parameter accordingly.
BUG=b:113101335 TEST=Tested in thermal chamber by thermal team. See comment 148 / 153 in the bug.
Change-Id: Ie18be94fc1e7476755fb0e6947cce559854a82dd Signed-off-by: Puthikorn Voravootivat puthik@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/33180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@google.com Reviewed-by: Bob Moragues moragues@google.com --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Bob Moragues: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl index 570fbbb..6863372 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl @@ -29,12 +29,12 @@
#define DPTF_TSR2_SENSOR_ID 3 #define DPTF_TSR2_SENSOR_NAME "DRAM" -#define DPTF_TSR2_PASSIVE 55 +#define DPTF_TSR2_PASSIVE 53 #define DPTF_TSR2_CRITICAL 75
#define DPTF_TSR3_SENSOR_ID 4 #define DPTF_TSR3_SENSOR_NAME "eMMC" -#define DPTF_TSR3_PASSIVE 52 +#define DPTF_TSR3_PASSIVE 50 #define DPTF_TSR3_CRITICAL 75
#undef DPTF_ENABLE_FAN_CONTROL
-
Bob Moragues (Code Review) -
Caveh Jalali (Code Review)
-
Furquan Shaikh (Code Review)
-
Puthikorn Voravootivat (Code Review)