Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31152
Change subject: lib/hardwaremain: One more typo ACPI ......................................................................
lib/hardwaremain: One more typo ACPI
CB:31139 fix few ACPI type error. Here is one more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/nhlt.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31152/1
diff --git a/src/include/nhlt.h b/src/include/nhlt.h index a361ed8..e4cfcf6 100644 --- a/src/include/nhlt.h +++ b/src/include/nhlt.h @@ -54,7 +54,7 @@ /* Obtain an nhlt object for adding endpoints. Returns NULL on error. */ struct nhlt *nhlt_init(void);
-/* Return the size of the NHLT table including APCI header. */ +/* Return the size of the NHLT table including ACPI header. */ size_t nhlt_current_size(struct nhlt *nhlt);
/*
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: One more typo ACPI ......................................................................
Patch Set 1: Code-Review+2
Hello HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31152
to look at the new patch set (#2).
Change subject: lib/hardwaremain: Few more typo ACPI error ......................................................................
lib/hardwaremain: Few more typo ACPI error
CB:31139 fix few ACPI type error. Here is few more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/nhlt.h M src/mainboard/hp/dl165_g6_fam10/romstage.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31152/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo ACPI error ......................................................................
Patch Set 2: Code-Review+2
Hello HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31152
to look at the new patch set (#3).
Change subject: lib/hardwaremain: Few more typo error(acpi/ioapic) ......................................................................
lib/hardwaremain: Few more typo error(acpi/ioapic)
CB:31139 fix few ACPI type error. Here is few more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/nhlt.h M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/southbridge/broadcom/bcm5785/early_setup.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31152/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(acpi/ioapic) ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... File src/southbridge/broadcom/bcm5785/early_setup.c:
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... PS3, Line 169: ioapic IOAPIC ?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(acpi/ioapic) ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... File src/southbridge/broadcom/bcm5785/early_setup.c:
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... PS3, Line 169: ioapic
IOAPIC ?
yes. from chipset its looks like to be IOAPIC enable bit only
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(acpi/ioapic) ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... File src/southbridge/broadcom/bcm5785/early_setup.c:
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... PS3, Line 169: ioapic
yes. from chipset its looks like to be IOAPIC enable bit only […]
no, I mean captal letters lol
Hello HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31152
to look at the new patch set (#4).
Change subject: lib/hardwaremain: Few more typo error(ACPI/IOAPIC) ......................................................................
lib/hardwaremain: Few more typo error(ACPI/IOAPIC)
CB:31139 fix few ACPI type error. Here is few more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/nhlt.h M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/southbridge/broadcom/bcm5785/early_setup.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31152/4
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(ACPI/IOAPIC) ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... File src/southbridge/broadcom/bcm5785/early_setup.c:
https://review.coreboot.org/#/c/31152/3/src/southbridge/broadcom/bcm5785/ear... PS3, Line 169: ioapic
no, I mean captal letters lol
:) done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(ACPI/IOAPIC) ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Few more typo error(ACPI/IOAPIC) ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31152/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31152/4//COMMIT_MSG@7 PS4, Line 7: lib/hardwaremain: Few more typo error(ACPI/IOAPIC) Just src: as prefix. Also please add a verb (in imperative mood) to make it a statement.
src: Fix more ACPI/IOAPIC typos
https://review.coreboot.org/#/c/31152/4//COMMIT_MSG@9 PS4, Line 9: fix fixes
Hello HAOUAS Elyes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31152
to look at the new patch set (#5).
Change subject: lib/hardwaremain: Fix more ACPI/IOAPIC typos ......................................................................
lib/hardwaremain: Fix more ACPI/IOAPIC typos
CB:31139 fixs few ACPI type error. Here is few more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/nhlt.h M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/southbridge/broadcom/bcm5785/early_setup.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31152/5
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31152 )
Change subject: lib/hardwaremain: Fix more ACPI/IOAPIC typos ......................................................................
lib/hardwaremain: Fix more ACPI/IOAPIC typos
CB:31139 fixs few ACPI type error. Here is few more typo mistake.
Change-Id: Ieecf0ba8fe09ed5003d5ae766079b8f83cc891b9 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/31152 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/nhlt.h M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/southbridge/broadcom/bcm5785/early_setup.c 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/include/nhlt.h b/src/include/nhlt.h index a361ed8..e4cfcf6 100644 --- a/src/include/nhlt.h +++ b/src/include/nhlt.h @@ -54,7 +54,7 @@ /* Obtain an nhlt object for adding endpoints. Returns NULL on error. */ struct nhlt *nhlt_init(void);
-/* Return the size of the NHLT table including APCI header. */ +/* Return the size of the NHLT table including ACPI header. */ size_t nhlt_current_size(struct nhlt *nhlt);
/* diff --git a/src/mainboard/hp/dl165_g6_fam10/romstage.c b/src/mainboard/hp/dl165_g6_fam10/romstage.c index 5b19688..6554eb1 100644 --- a/src/mainboard/hp/dl165_g6_fam10/romstage.c +++ b/src/mainboard/hp/dl165_g6_fam10/romstage.c @@ -197,7 +197,7 @@ fill_mem_ctrl(sysinfo->nodes, sysinfo->ctrl, spd_addr); enable_smbus();
- //do we need apci timer, tsc...., only debug need it for better output + //do we need ACPI timer, tsc...., only debug need it for better output /* all ap stopped? */ // init_timer(); // Need to use TMICT to synchronize FID/VID
diff --git a/src/southbridge/broadcom/bcm5785/early_setup.c b/src/southbridge/broadcom/bcm5785/early_setup.c index df7217c..ee9967d 100644 --- a/src/southbridge/broadcom/bcm5785/early_setup.c +++ b/src/southbridge/broadcom/bcm5785/early_setup.c @@ -166,7 +166,7 @@ // enable device on bcm5785 at first dev = pci_locate_device(PCI_ID(0x1166, 0x0205), 0); dword = pci_read_config32(dev, 0x64); - dword |= (1 << 15) | (1 << 11) | (1 << 3); // ioapci enable + dword |= (1 << 15) | (1 << 11) | (1 << 3); // IOAPIC enable dword |= 1 << 8; // USB enable dword |= /* (1 << 27)|*/ 1 << 14; // IDE enable pci_write_config32(dev, 0x64, dword);
-
HAOUAS Elyes (Code Review) -
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)