Change in coreboot[master]: nb/intel/haswell/pei_data.h: Add ULT system type

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

24 Apr 2020 24 Apr '20

2:38 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

nb/intel/haswell/pei_data.h: Add ULT system type

Looks like 5 is a valid system type, as Google Beltino and Slippy are using it. According to comments on these mainboards' code, this value corresponds to ULT systems. So, add it to the comment on the pei_data struct, which was likely copied from Sandy Bridge and was not updated.

Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/pei_data.h 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/40692/1

diff --git a/src/northbridge/intel/haswell/pei_data.h b/src/northbridge/intel/haswell/pei_data.h index 17b7c18..455b043 100644 --- a/src/northbridge/intel/haswell/pei_data.h +++ b/src/northbridge/intel/haswell/pei_data.h @@ -81,7 +81,8 @@ uint32_t pmbase; uint32_t gpiobase; uint32_t temp_mmio_base; - uint32_t system_type; // 0 Mobile, 1 Desktop/Server + /* Board type: 0 => Mobile, 1 => Desktop/Server, 5 => ULT, Others => Reserved */ + uint32_t system_type; uint32_t tseg_size; uint8_t spd_addresses[4]; int boot_mode;

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Matt DeVillier (Code Review)

24 Apr 24 Apr

2:48 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 Apr 2020 17:48:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

2:55 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pei_data.h:

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... PS1, Line 84: Board type nit: should this match the variable name?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 Apr 2020 17:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

3:28 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 Apr 2020 18:28:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

25 Apr 25 Apr

12:02 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pei_data.h:

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... PS1, Line 84: Board type

...

nit: should this match the variable name?

Looks like the MRC uses these values as board types, as they match the ones in this enum:

https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Intel/Coffee...

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 25 Apr 2020 15:02:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com Gerrit-MessageType: comment

Matt DeVillier (Code Review)

7:04 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pei_data.h:

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... PS1, Line 84: Board type

...

Looks like the MRC uses these values as board types, as they match the ones in this enum: […]

my point was that the comment says board name, but the variable is system_type, so there's an incongruity there.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 25 Apr 2020 22:04:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

26 Apr 26 Apr

9:35 a.m.

Hello Felix Singer, build bot (Jenkins), Matt DeVillier, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40692

to look at the new patch set (#2).

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

nb/intel/haswell/pei_data.h: Add ULT system type

Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/pei_data.h 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/40692/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9:35 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pei_data.h:

https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe... PS1, Line 84: Board type

...

my point was that the comment says board name, but the variable is system_type, so there's an incong […]

Done.

Note to self: Do not waste any more time on this struct. There are better things to do.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 26 Apr 2020 12:35:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Matt DeVillier (Code Review)

1:18 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 26 Apr 2020 16:18:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

29 Apr 29 Apr

5:44 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 2:

...

Patch Set 2: Code-Review+2

Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Apr 2020 20:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5:44 p.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

nb/intel/haswell/pei_data.h: Add ULT system type

Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40692 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/northbridge/intel/haswell/pei_data.h 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved

diff --git a/src/northbridge/intel/haswell/pei_data.h b/src/northbridge/intel/haswell/pei_data.h index 17b7c18..643b830 100644 --- a/src/northbridge/intel/haswell/pei_data.h +++ b/src/northbridge/intel/haswell/pei_data.h @@ -81,7 +81,8 @@ uint32_t pmbase; uint32_t gpiobase; uint32_t temp_mmio_base; - uint32_t system_type; // 0 Mobile, 1 Desktop/Server + /* System type: 0 => Mobile, 1 => Desktop/Server, 5 => ULT, Others => Reserved */ + uint32_t system_type; uint32_t tseg_size; uint8_t spd_addresses[4]; int boot_mode;

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

1 May 1 May

10:30 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )

Change subject: nb/intel/haswell/pei_data.h: Add ULT system type ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2896 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2895 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2894 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2893

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 01 May 2020 13:30:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1814

days inactive

1821

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Angel Pons (Code Review)
Felix Singer (Code Review)
Matt DeVillier (Code Review)