Attention is currently required from: Fei Yan, Hung-Te Lin.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email )
Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82076/comment/1e3cec9d_3a54d0ca :
PS3, Line 9: Set MFG to domain 6.
: Set MFG remap in infra and sub infra, so that MFG can switch to protect mode by MFG register.
: Set MFG slave MFG_S_S-2 and MFG_S_S-5 permission from NO_PROTECTION to SEC_RW_ONLY for domain 0,
: so that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5.
72 characters per line for the commit message.
Patchset:
PS3:
Please resolve the review comments by selecting the checkbox `Resolved`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82076?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d
Gerrit-Change-Number: 82076
Gerrit-PatchSet: 3
Gerrit-Owner: Fei Yan
fei.yan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Fei Yan
fei.yan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Fei Yan
fei.yan@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Apr 2024 17:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment