Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45581 )
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
mb/google/zork: update telemetry settings for dirinboz
update telemetry to improve the performance.
BUG=b:154863613 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I464b90550aaa1666ce3f2393856bf46fe7686d1d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45581/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 05c5110..ead478c 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -17,6 +17,10 @@
# End : OPN Performance Configuration
+ register "telemetry_vddcr_vdd_slope" = "42465" #mA + register "telemetry_vddcr_vdd_offset" = "69" + register "telemetry_vddcr_soc_slope" = "42667" #mA + register "telemetry_vddcr_soc_offset" = "167"
# I2C2 for touchscreen and trackpad register "i2c[2]" = "{
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45581 )
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45581/1//COMMIT_MSG@11 PS1, Line 11: 154863613 Bug # looks wrong. It is for morphius.
https://review.coreboot.org/c/coreboot/+/45581/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45581/1/src/mainboard/google/zork/v... PS1, Line 18: # End : OPN Performance Configuration nit: This should be placed after the "telemetry_vddcr_soc_offset" on line 23.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45581
to look at the new patch set (#2).
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
mb/google/zork: update telemetry settings for dirinboz
update telemetry to improve the performance.
BUG=b:168585079 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I464b90550aaa1666ce3f2393856bf46fe7686d1d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45581/2
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45581
to look at the new patch set (#3).
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
mb/google/zork: update telemetry settings for dirinboz
update telemetry to improve the performance.
BUG=b:168585079 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I464b90550aaa1666ce3f2393856bf46fe7686d1d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45581/3
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45581 )
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45581/1//COMMIT_MSG@11 PS1, Line 11: 154863613
Bug # looks wrong. It is for morphius.
Done
https://review.coreboot.org/c/coreboot/+/45581/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45581/1/src/mainboard/google/zork/v... PS1, Line 18: # End : OPN Performance Configuration
nit: This should be placed after the "telemetry_vddcr_soc_offset" on line 23.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45581 )
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45581 )
Change subject: mb/google/zork: update telemetry settings for dirinboz ......................................................................
mb/google/zork: update telemetry settings for dirinboz
update telemetry to improve the performance.
BUG=b:168585079 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I464b90550aaa1666ce3f2393856bf46fe7686d1d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45581 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 05c5110..905bc88 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -15,9 +15,12 @@ register "stapm_time_constant" = "2500" #second register "sustained_power_limit" = "4800" #mw
+ register "telemetry_vddcr_vdd_slope" = "42465" #mA + register "telemetry_vddcr_vdd_offset" = "69" + register "telemetry_vddcr_soc_slope" = "42667" #mA + register "telemetry_vddcr_soc_offset" = "167" # End : OPN Performance Configuration
- # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
-
Furquan Shaikh (Code Review) -
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)