Attention is currently required from: SH Kim. Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/57327
to review the following change.
Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable ......................................................................
lib/edid_fill_fb: Make framebuffer orientation to be configurable
Some panels have portrait orientation as default, this change makes framebuffer orientation to be configurable to adjust the proper firmware screen UI orientation for them.
BUG=b:194967458 TEST=Build and checked the firmware screen UI orientation on bugzzy BRANCH=None
Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/lib/Kconfig M src/lib/edid_fill_fb.c 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/57327/1
diff --git a/src/lib/Kconfig b/src/lib/Kconfig index 0f651b3..614d688 100644 --- a/src/lib/Kconfig +++ b/src/lib/Kconfig @@ -109,3 +109,10 @@
The SoC needs to define a payload_preload_cache region where the raw payload can be placed. + +config FRAMEBUFFER_ORIENTATION_OVERRIDE + int + default -1 + help + Overrides framebuffer orientation setting. We should set this with one + of lb_fb_orientation. '-1' means disabled. diff --git a/src/lib/edid_fill_fb.c b/src/lib/edid_fill_fb.c index 7e8aa95..a57828e 100644 --- a/src/lib/edid_fill_fb.c +++ b/src/lib/edid_fill_fb.c @@ -74,6 +74,9 @@ /* Update */ info->fb = *fb;
+ if (CONFIG_FRAMEBUFFER_ORIENTATION_OVERRIDE != 1) + info->fb.orientation = CONFIG_FRAMEBUFFER_ORIENTATION_OVERRIDE; + list_insert_after(&info->node, &list);
return info;