Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Isaac Lee, Chris Wang, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73124 )
Change subject: soc/amd/mendocino: Remove the SPL DPTC parameter
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73124/comment/3a247cee_a2dbb407
PS6, Line 263: # Remove the sustained_power_limit_mW when STT is enabled
: register "sustained_power_limit_mW" = "15000"
Should the sustained_power_limit_mW move to skyrim/overridetree.cb from here?
Based on the experience, the sustained_power_limit_mW will be used in all the overridetree.cb if it is included in baseboard/devicetree.cb.
Is there a way to remove sustained_power_limit_mW if it is already configured in baseboard/devicetree.cb?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73124
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e6dad7d24883f8aadce83ebac401ecd4137d61a
Gerrit-Change-Number: 73124
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Mar 2023 06:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment