Attention is currently required from: Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68100 )
Change subject: pc80/i8254: Add speaker beep function ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/pc80/pc/i8254.c:
https://review.coreboot.org/c/coreboot/+/68100/comment/b5902c1a_5fdeebf9 PS1, Line 7: #include <delay.h>
nit: existing includes seem to be sorted alphabetically
Done
https://review.coreboot.org/c/coreboot/+/68100/comment/e30ff5f0_cb271d22 PS1, Line 129: /* Block for specified miliseconds */
'miliseconds' may be misspelled - perhaps 'milliseconds'? […]
Done