Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 74:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 28: register "SkipExtGfxScan" = "1"
No, as the aspeed VGA is assumed to be "onboard" as it's part of the devicetree and coreboot will di […]
Ok, thanks for the clarification.
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 210: device pci 01.1 on
- I think it would be better to use width limit. […]
Sorry, I meant "link training", not bus.
"bus training" is the wrong term for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 74
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Keno Fischer
keno@alumni.harvard.edu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: T. Hudson
trammell.hudson@gmail.com
Gerrit-Reviewer: Trammell Hudson
hudson@trmm.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Aug 2019 09:23:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment