Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32232
Change subject: src: Fix remaining #include <timer.h> ......................................................................
src: Fix remaining #include <timer.h>
Follow up to add76f91d5 (src: Use #include <timer.h> when appropriate).
Change-Id: I7813daa0b73039ec76d33a16ce3ae0ce6cc7f2cc Signed-off-by: Nico Huber nico.h@gmx.de --- M src/device/oprom/yabel/biosemu.c M src/include/thread.h M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/usb.c 5 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/32232/1
diff --git a/src/device/oprom/yabel/biosemu.c b/src/device/oprom/yabel/biosemu.c index 1c94d92..d0586c2 100644 --- a/src/device/oprom/yabel/biosemu.c +++ b/src/device/oprom/yabel/biosemu.c @@ -53,6 +53,7 @@ #include "compat/rtas.h"
#if CONFIG(X86EMU_DEBUG_TIMINGS) +#include <timer.h> struct mono_time zero; #endif
diff --git a/src/include/thread.h b/src/include/thread.h index e8041c7..e6af2ef 100644 --- a/src/include/thread.h +++ b/src/include/thread.h @@ -18,7 +18,6 @@ #include <stddef.h> #include <stdint.h> #include <bootstate.h> -#include <timer.h> #include <arch/cpu.h>
#if CONFIG(COOP_MULTITASKING) && !defined(__SMM__) && !defined(__PRE_RAM__) diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index 31fdc3d..cd7c1f2 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -16,7 +16,6 @@ #include <types.h> #include <console/console.h> #include <delay.h> -#include <timer.h> #include <timestamp.h> #include <commonlib/helpers.h> #include <string.h> diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index db8b7a1..5904cb3 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -17,7 +17,6 @@ #include <types.h> #include <console/console.h> #include <delay.h> -#include <timer.h> #include <timestamp.h>
#include <gpio.h> diff --git a/src/soc/qualcomm/qcs405/usb.c b/src/soc/qualcomm/qcs405/usb.c index b727248..49eac72 100644 --- a/src/soc/qualcomm/qcs405/usb.c +++ b/src/soc/qualcomm/qcs405/usb.c @@ -20,7 +20,6 @@ #include <delay.h> #include <soc/usb.h> #include <soc/clock.h> -#include <timer.h>
/* USB BASE ADDRESS */ #define USB_HOST0_DWC3_BASE 0x758C100
Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32232 )
Change subject: src: Fix remaining #include <timer.h> ......................................................................
src: Fix remaining #include <timer.h>
Follow-up to add76f91d5 (src: Use #include <timer.h> when appropriate).
Change-Id: I7813daa0b73039ec76d33a16ce3ae0ce6cc7f2cc Signed-off-by: Nico Huber nico.h@gmx.de --- M src/device/oprom/yabel/biosemu.c M src/include/thread.h M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/usb.c 5 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/32232/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32232 )
Change subject: src: Fix remaining #include <timer.h> ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32232 )
Change subject: src: Fix remaining #include <timer.h> ......................................................................
src: Fix remaining #include <timer.h>
Follow-up to add76f91d5 (src: Use #include <timer.h> when appropriate).
Change-Id: I7813daa0b73039ec76d33a16ce3ae0ce6cc7f2cc Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/32232 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/device/oprom/yabel/biosemu.c M src/include/thread.h M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/gpio.c M src/soc/qualcomm/qcs405/usb.c 5 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/device/oprom/yabel/biosemu.c b/src/device/oprom/yabel/biosemu.c index 1c94d92..d0586c2 100644 --- a/src/device/oprom/yabel/biosemu.c +++ b/src/device/oprom/yabel/biosemu.c @@ -53,6 +53,7 @@ #include "compat/rtas.h"
#if CONFIG(X86EMU_DEBUG_TIMINGS) +#include <timer.h> struct mono_time zero; #endif
diff --git a/src/include/thread.h b/src/include/thread.h index e8041c7..e6af2ef 100644 --- a/src/include/thread.h +++ b/src/include/thread.h @@ -18,7 +18,6 @@ #include <stddef.h> #include <stdint.h> #include <bootstate.h> -#include <timer.h> #include <arch/cpu.h>
#if CONFIG(COOP_MULTITASKING) && !defined(__SMM__) && !defined(__PRE_RAM__) diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index 31fdc3d..cd7c1f2 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -16,7 +16,6 @@ #include <types.h> #include <console/console.h> #include <delay.h> -#include <timer.h> #include <timestamp.h> #include <commonlib/helpers.h> #include <string.h> diff --git a/src/soc/qualcomm/qcs405/gpio.c b/src/soc/qualcomm/qcs405/gpio.c index db8b7a1..5904cb3 100644 --- a/src/soc/qualcomm/qcs405/gpio.c +++ b/src/soc/qualcomm/qcs405/gpio.c @@ -17,7 +17,6 @@ #include <types.h> #include <console/console.h> #include <delay.h> -#include <timer.h> #include <timestamp.h>
#include <gpio.h> diff --git a/src/soc/qualcomm/qcs405/usb.c b/src/soc/qualcomm/qcs405/usb.c index b727248..49eac72 100644 --- a/src/soc/qualcomm/qcs405/usb.c +++ b/src/soc/qualcomm/qcs405/usb.c @@ -20,7 +20,6 @@ #include <delay.h> #include <soc/usb.h> #include <soc/clock.h> -#include <timer.h>
/* USB BASE ADDRESS */ #define USB_HOST0_DWC3_BASE 0x758C100
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)