[M] Change in coreboot[main]: mb/starlabs/*: Configure GPIO UPDs for eSPI - coreboot-gerrit

7 Jan 2025


      Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85691?usp=email )
Change subject: mb/starlabs/*: Configure GPIO UPDs for eSPI
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85691/comment/69ab8b47_519e28cf?usp... :
PS6, Line 9: FSP defaults to using pins that are used for LPC; given that
           : coreboot and these boards only supports eSPI, set these pins
           : accordingly.
...
what's the end result of setting these vs not?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85691?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247
Gerrit-Change-Number: 85691
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 07 Jan 2025 08:57:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com