Change in coreboot[master]: soc/amd/cezanne: add pci_devs.h - coreboot-gerrit

21 Jan 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49781 )
Change subject: soc/amd/cezanne: add pci_devs.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/cezanne/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/49781/comment/74760660_80f28aed 
PS1, Line 129: #define DF_F0_DEVFN		PCI_DEVFN(DF_DEV, 0)
             : #define SOC_DF_F0_DEV		_SOC_DEV(DF_DEV, 0)
...
yep, there's a mask applied, but that might cause some possibly hard to find malfunction for functio […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e3ee4c98a85068dc87ef96aaf65a09c6df1572d
Gerrit-Change-Number: 49781
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 21 Jan 2021 23:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment