William Wei has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
mb/google/volteer/malefor: Enable touch screen
Enable Goodix touch screen and ensure it works properly.
BUG=b:154191288 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the Goodix touch screen function.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/malefor/overridetree.cb 3 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/40598/1
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 0870c61..04b2bb0 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -3,6 +3,7 @@ select BOARD_ROMSIZE_KB_32768 select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID select DRIVERS_SPI_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID diff --git a/src/mainboard/google/volteer/variants/malefor/gpio.c b/src/mainboard/google/volteer/variants/malefor/gpio.c index 71a03e6..1a8be13 100644 --- a/src/mainboard/google/volteer/variants/malefor/gpio.c +++ b/src/mainboard/google/volteer/variants/malefor/gpio.c @@ -205,7 +205,7 @@ /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */ PAD_NC(GPP_E6, NONE), /* E7 : CPU_GP1 ==> USI_INT */ - PAD_CFG_GPI(GPP_E7, NONE, DEEP), + PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE), /* E8 : SPI1_CS1# ==> SLP_S0IX */ PAD_CFG_GPO(GPP_E8, 0, DEEP), /* E9 : USB2_OC0# ==> USB_C1_OC_ODL */ diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb index 32204c5..88d3e68 100644 --- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb @@ -1,6 +1,25 @@ chip soc/intel/tigerlake
device domain 0 on + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" + register "generic.reset_delay_ms" = "500" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + end # I2C1 + end
end
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1: Code-Review+1
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... PS1, Line 12: 500 That is a huge delay. Does that match the datasheet? This is going to add 500ms for every resume.
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... PS1, Line 12: 500
That is a huge delay. Does that match the datasheet? This is going to add 500ms for every resume.
Datasheet requires a typical delay equal or more than 10ms. We usually set this to 150ms, let me verify the function with 150ms.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... PS1, Line 12: 500
Datasheet requires a typical delay equal or more than 10ms. […]
Why don't just follow the spec? Will the function fail?
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... PS1, Line 12: 500
Why don't just follow the spec? Will the function fail?
With newer Goodix firmware you should be able to use 120ms.
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Sorry to make you confused, the datasheet define the reset delay should equal or longer than 10ms, doesn't contain the typical value. I saw other project uses the same Goodix IC and the reset delay time were 150ms. As Duncan's suggestion, will change to 120ms and then verify the function.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Jes Klinke, Dossym Nurmukhanov, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40598
to look at the new patch set (#2).
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
mb/google/volteer/malefor: Enable touch screen
Enable Goodix touch screen and ensure it works properly.
BUG=b:154191288 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the Goodix touch screen function.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/malefor/overridetree.cb 3 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/40598/2
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/1/src/mainboard/google/voltee... PS1, Line 12: 500
With newer Goodix firmware you should be able to use 120ms.
Change reset delay to 120ms and verify the Goodix touch panel works properly. Done.
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1 should be 0
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 124: 1 should be 0
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
should be 0
Alex@, only change EN_PP3300_TOUCHSCREEN to 0, verified that touch screen has no function.
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 124: 1
should be 0
Alex@, only change USI_RST_L to 0, verified that touch screen has no function.
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
Alex@, only change EN_PP3300_TOUCHSCREEN to 0, verified that touch screen has no function.
right. make sure you are testing with https://review.coreboot.org/c/coreboot/+/40550/6 (already merged).
The CL I pointed out adds the GPIO ops so no need to force-enable these GPIOs
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 124: 1
Alex@, only change USI_RST_L to 0, verified that touch screen has no function.
right. make sure you are testing with https://review.coreboot.org/c/coreboot/+/40550/6 (already merged).
The CL I pointed out adds the GPIO ops so no need to force-enable these GPIOs
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 2:
Patch Set 2:
(2 comments)
OK, since the GPIO ops has merged, I'll remove the force-enable GPIOs. Verified touch screen function pass on my side.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Alex Levin, Jes Klinke, Dossym Nurmukhanov, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40598
to look at the new patch set (#3).
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
mb/google/volteer/malefor: Enable touch screen
Enable Goodix touch screen and ensure it works properly.
BUG=b:154191288 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the Goodix touch screen function.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c --- M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/malefor/overridetree.cb 2 files changed, 22 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/40598/3
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patch Set 2:
(2 comments)
All comments done, please help to review again.
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
right. make sure you are testing with https://review.coreboot. […]
Done, thanks for your reminding.
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 124: 1
right. make sure you are testing with https://review.coreboot. […]
Done, thanks for your reminding.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
Done, thanks for your reminding.
Will setting to 0 cause issues for recovery mode?
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/3/src/mainboard/google/voltee... PS3, Line 22: please remove blank line 22
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 3: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Alex Levin, Jes Klinke, Dossym Nurmukhanov, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40598
to look at the new patch set (#4).
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
mb/google/volteer/malefor: Enable touch screen
Enable Goodix touch screen and ensure it works properly.
BUG=b:154191288 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the Goodix touch screen function.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c --- M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/malefor/overridetree.cb 2 files changed, 21 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/40598/4
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/3/src/mainboard/google/voltee... PS3, Line 22:
please remove blank line 22
Removed, done
William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
Will setting to 0 cause issues for recovery mode?
May I know how to verify this function? I've entered recovery mode and then found there's no chance to use touch screen.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/40598/2/src/mainboard/google/voltee... PS2, Line 22: 1
May I know how to verify this function? […]
you're right. as long as the device tree entries you're adding with this patch tell linux how to enable the touchscreen, you should be fine.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... PS4, Line 17: register "generic.has_power_resource" = "1" actually, do we also need "generic.disable_gpio_export_in_crs" = "1" here?
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... PS4, Line 17: register "generic.has_power_resource" = "1"
actually, do we also need […]
from what I understand this is to disable the GPIO resources from _CRS, which should be used in case reset and enable GPIOs are not provided, which isn't the case here.
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee... PS4, Line 17: register "generic.has_power_resource" = "1"
from what I understand this is to disable the GPIO resources from _CRS, which should be used in case […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
mb/google/volteer/malefor: Enable touch screen
Enable Goodix touch screen and ensure it works properly.
BUG=b:154191288 TEST=FW_NAME=malefor emerge-volteer coreboot chromeos-bootimage Boot to kernel and check the Goodix touch screen function.
Signed-off-by: William Wei wenxu.wei@bitland.corp-partner.google.com Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c Reviewed-on: https://review.coreboot.org/c/coreboot/+/40598 Reviewed-by: Alex Levin levinale@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/malefor/gpio.c M src/mainboard/google/volteer/variants/malefor/overridetree.cb 2 files changed, 21 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Alex Levin: Looks good to me, but someone else must approve William Wei: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/malefor/gpio.c b/src/mainboard/google/volteer/variants/malefor/gpio.c index 71a03e6..2804859 100644 --- a/src/mainboard/google/volteer/variants/malefor/gpio.c +++ b/src/mainboard/google/volteer/variants/malefor/gpio.c @@ -19,7 +19,7 @@ /* A7 : I2S2_SCLK ==> EN_PP3300_TRACKPAD */ PAD_CFG_GPO(GPP_A7, 1, DEEP), /* A8 : I2S2_SFRM ==> EN_PP3300_TOUCHSCREEN */ - PAD_CFG_GPO(GPP_A8, 1, DEEP), + PAD_CFG_GPO(GPP_A8, 0, DEEP), /* A9 : I2S2_TXD ==> EC_IN_RW_OD */ PAD_CFG_GPI(GPP_A9, NONE, DEEP), /* A10 : I2S2_RXD ==> EN_SPKR_PA */ @@ -121,7 +121,7 @@ /* C9 : UART0_TXD ==> UART_PCH_TX_DEBUG_RX */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), /* C10 : UART0_RTS# ==> USI_RST_L */ - PAD_CFG_GPO(GPP_C10, 1, DEEP), + PAD_CFG_GPO(GPP_C10, 0, DEEP), /* C11 : UART0_CTS# ==> NOT USED */ PAD_NC(GPP_C11, NONE), /* C12 : UART1_RXD ==> MEM_STRAP_0 */ @@ -205,7 +205,7 @@ /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */ PAD_NC(GPP_E6, NONE), /* E7 : CPU_GP1 ==> USI_INT */ - PAD_CFG_GPI(GPP_E7, NONE, DEEP), + PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE), /* E8 : SPI1_CS1# ==> SLP_S0IX */ PAD_CFG_GPO(GPP_E8, 0, DEEP), /* E9 : USB2_OC0# ==> USB_C1_OC_ODL */ diff --git a/src/mainboard/google/volteer/variants/malefor/overridetree.cb b/src/mainboard/google/volteer/variants/malefor/overridetree.cb index 32204c5..8d4c6ea 100644 --- a/src/mainboard/google/volteer/variants/malefor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/malefor/overridetree.cb @@ -1,6 +1,24 @@ chip soc/intel/tigerlake
device domain 0 on + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + end # I2C1 end
end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3000 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2999 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2998 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2997
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Alex Levin (Code Review)
-
Caveh Jalali (Code Review)
-
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
William Wei (Code Review)
-
Zhuohao Lee (Code Review)