Attention is currently required from: Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78228?usp=email )
Change subject: sb/intel/bd82x6x: Improve SLCAP ......................................................................
Patch Set 2:
(1 comment)
File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/78228/comment/bed2ac1e_4a099e8c : PS2, Line 152: reg32 |= (slot_number++ << 19);
For now, maybe pre-increment, such that the first assignment is 1, to make a distinction from all th […]
The SI Slot Implemented flag is now always set for enabled or hot pluggable ports, thus the check would always evaluate to true.
The spec is the other way around: It says PCI_EXP_SLTCAP must be present when SI is set, but it doesn't cover the case where SI isn't set.
-
Patrick Rudolph (Code Review)