Change in coreboot[master]: mb/google/volteer: Enable USB4 retimer driver

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Duncan Laurie (Code Review)

29 Aug 2020 29 Aug '20

7:07 a.m.

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

mb/google/volteer: Enable USB4 retimer driver

Enable the USB4 retimer driver with GPP_H10 as the power control.

Signed-off-by: Duncan Laurie dlaurie@google.com Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/44919/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 4867fea..44f6738 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -8,6 +8,7 @@ select DRIVERS_I2C_SX9310 select DRIVERS_INTEL_DPTF select DRIVERS_INTEL_PMC + select DRIVERS_INTEL_USB4_RETIMER select DRIVERS_I2C_MAX98373 select DRIVERS_INTEL_SOUNDWIRE select DRIVERS_SPI_ACPI diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 2717acd..82e3e5a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -392,6 +392,10 @@ device ref tbt_dma0 on probe DB_USB USB4_GEN2 probe DB_USB USB4_GEN3 + chip drivers/intel/usb4/retimer + register "power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H10)" + device generic 0 on end + end end device ref gna on end device ref north_xhci on end

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

3 Sep 3 Sep

12:20 p.m.

Tim Wawrzynczak has uploaded a new patch set (#2) to the change originally created by Duncan Laurie. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

mb/google/volteer: Enable USB4 retimer driver

Enable the USB4 retimer driver with GPP_H10 as the power control.

Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/44919/2

Caveh Jalali (Code Review)

9:30 p.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... PS2, Line 396: ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H10) my reading of the BB spec is that this is a signal to keep the chip from going to sleep. i'm not sure why we unconditionally assert this in gpio.c now. also, it's active high.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Sep 2020 11:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

10 Sep 10 Sep

5:43 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... PS2, Line 396: ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H10)

...

my reading of the BB spec is that this is a signal to keep the chip from […]

Right, I think this is for FW updates, so it can apply the update, then turn it off and on again? Will fix the polarity.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 19:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:45 a.m.

Tim Wawrzynczak has uploaded a new patch set (#3) to the change originally created by Duncan Laurie. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

mb/google/volteer: Enable USB4 retimer driver

Enable the USB4 retimer driver with GPP_H10 as the power control.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/44919/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nick Vaccaro (Code Review)

19 Sep 19 Sep

6:04 a.m.

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 18 Sep 2020 20:04:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7 Oct 7 Oct

3:34 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee... PS2, Line 396: ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H10)

...

Right, I think this is for FW updates, so it can apply the update, then turn it off and on again? Wi […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 06 Oct 2020 16:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:17 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... PS4, Line 395: drivers/intel/usb4/retimer Just curious: Is this retimer used on all variants?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Oct 2020 00:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

8 Oct 8 Oct

5:32 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... PS4, Line 395: drivers/intel/usb4/retimer

...

Just curious: Is this retimer used on all variants?

The retimer is required for any that have usb4 so the probe statements should enable/disable it properly. we're using DB_USB because that is what volteer had, but it can be on the MLB (like voxel) where it still sets DB_USB=USB4_GEN3 at least.

All the usb4 designs also seem to stick to GPP_H10 for power control, even if it has multiple retimers, although that could in theory change in a future design.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Oct 2020 18:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10 Oct 10 Oct

4:48 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/44919/4/src/mainboard/google/voltee... PS4, Line 395: drivers/intel/usb4/retimer

...

The retimer is required for any that have usb4 so the probe statements should enable/disable it prop […]

Ack.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 5 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 09 Oct 2020 17:48:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

19 Oct 19 Oct

5:52 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44919 )

Change subject: mb/google/volteer: Enable USB4 retimer driver ......................................................................

mb/google/volteer: Enable USB4 retimer driver

Enable the USB4 retimer driver with GPP_H10 as the power control.

Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44919 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index edc9c91..69f58b5 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -8,6 +8,7 @@ select DRIVERS_I2C_SX9310 select DRIVERS_INTEL_DPTF select DRIVERS_INTEL_PMC + select DRIVERS_INTEL_USB4_RETIMER select DRIVERS_I2C_MAX98373 select DRIVERS_INTEL_SOUNDWIRE select DRIVERS_SPI_ACPI diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 28d903f..7486aef 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -426,6 +426,10 @@ device ref tbt_dma0 on probe DB_USB USB4_GEN2 probe DB_USB USB4_GEN3 + chip drivers/intel/usb4/retimer + register "power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10)" + device generic 0 on end + end end device ref gna on end device ref north_xhci on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/44919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2 Gerrit-Change-Number: 44919 Gerrit-PatchSet: 9 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1449

days inactive

1501

days old

coreboot-gerrit@coreboot.org

10 comments

6 participants

tags (0)

participants (6)

Caveh Jalali (Code Review)
Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Nick Vaccaro (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)