Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38903 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Add missing include <device/pci_def.h> for the boards that are being switched away from ROMCC_BOOTBLOCK.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I83ff712f99388c4e6ea00a942eb57bcabb53a3fd --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/olivehill/irq_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/bap/ode_e20XX/irq_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/hp/abm/irq_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c 13 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/38903/1
diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/inagua/irq_tables.c +++ b/src/mainboard/amd/inagua/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/olivehill/irq_tables.c b/src/mainboard/amd/olivehill/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/olivehill/irq_tables.c +++ b/src/mainboard/amd/olivehill/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/parmer/irq_tables.c +++ b/src/mainboard/amd/parmer/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/persimmon/irq_tables.c +++ b/src/mainboard/amd/persimmon/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/south_station/irq_tables.c +++ b/src/mainboard/amd/south_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/thatcher/irq_tables.c +++ b/src/mainboard/amd/thatcher/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/union_station/irq_tables.c +++ b/src/mainboard/amd/union_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/bap/ode_e20XX/irq_tables.c b/src/mainboard/bap/ode_e20XX/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/bap/ode_e20XX/irq_tables.c +++ b/src/mainboard/bap/ode_e20XX/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/elmex/pcm205400/irq_tables.c b/src/mainboard/elmex/pcm205400/irq_tables.c index 804f52d..d114996 100644 --- a/src/mainboard/elmex/pcm205400/irq_tables.c +++ b/src/mainboard/elmex/pcm205400/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/gizmosphere/gizmo2/irq_tables.c b/src/mainboard/gizmosphere/gizmo2/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/gizmosphere/gizmo2/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo2/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/hp/abm/irq_tables.c b/src/mainboard/hp/abm/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/hp/abm/irq_tables.c +++ b/src/mainboard/hp/abm/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/frontrunner-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/frontrunner-af/irq_tables.c +++ b/src/mainboard/lippert/frontrunner-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/toucan-af/irq_tables.c b/src/mainboard/lippert/toucan-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/toucan-af/irq_tables.c +++ b/src/mainboard/lippert/toucan-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38903 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38903 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Add missing include <device/pci_def.h> for the boards that are being switched away from ROMCC_BOOTBLOCK.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I83ff712f99388c4e6ea00a942eb57bcabb53a3fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/38903 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/olivehill/irq_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/bap/ode_e20XX/irq_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/hp/abm/irq_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c 13 files changed, 13 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/inagua/irq_tables.c +++ b/src/mainboard/amd/inagua/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/olivehill/irq_tables.c b/src/mainboard/amd/olivehill/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/olivehill/irq_tables.c +++ b/src/mainboard/amd/olivehill/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/parmer/irq_tables.c +++ b/src/mainboard/amd/parmer/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/persimmon/irq_tables.c +++ b/src/mainboard/amd/persimmon/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/south_station/irq_tables.c +++ b/src/mainboard/amd/south_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/thatcher/irq_tables.c +++ b/src/mainboard/amd/thatcher/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/union_station/irq_tables.c +++ b/src/mainboard/amd/union_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/bap/ode_e20XX/irq_tables.c b/src/mainboard/bap/ode_e20XX/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/bap/ode_e20XX/irq_tables.c +++ b/src/mainboard/bap/ode_e20XX/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/elmex/pcm205400/irq_tables.c b/src/mainboard/elmex/pcm205400/irq_tables.c index 804f52d..d114996 100644 --- a/src/mainboard/elmex/pcm205400/irq_tables.c +++ b/src/mainboard/elmex/pcm205400/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/gizmosphere/gizmo2/irq_tables.c b/src/mainboard/gizmosphere/gizmo2/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/gizmosphere/gizmo2/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo2/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/hp/abm/irq_tables.c b/src/mainboard/hp/abm/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/hp/abm/irq_tables.c +++ b/src/mainboard/hp/abm/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/frontrunner-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/frontrunner-af/irq_tables.c +++ b/src/mainboard/lippert/frontrunner-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/toucan-af/irq_tables.c b/src/mainboard/lippert/toucan-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/toucan-af/irq_tables.c +++ b/src/mainboard/lippert/toucan-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38903 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/784 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/783 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/782
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
HAOUAS Elyes (Code Review)
-
Mike Banon (Code Review)
-
Patrick Georgi (Code Review)