Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38072 )
Change subject: mb/roda/rk886ex/devicetree.cb: Align comments ......................................................................
mb/roda/rk886ex/devicetree.cb: Align comments
Change-Id: I67e3149657c04f72aac0b20bc31af338129a13b2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/roda/rk886ex/devicetree.cb 1 file changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/38072/1
diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index 5bce304..93a4041 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -29,11 +29,11 @@
device domain 0 on subsystemid 0x4352 0x6886 inherit - device pci 00.0 on end # host bridge + device pci 00.0 on end # host bridge # auto detection: #device pci 01.0 off end # i945 PCIe root port - device pci 02.0 on end # vga controller - device pci 02.1 on end # display controller + device pci 02.0 on end # vga controller + device pci 02.1 on end # display controller
chip southbridge/intel/i82801gx register "pirqa_routing" = "0x0b" @@ -66,19 +66,19 @@ register "gen2_dec" = "0x00fc0601" # ?? register "gen3_dec" = "0x00040069" # EC decode ??
- device pci 1b.0 off end # High Definition Audio - device pci 1c.0 on end # PCIe port 1 - device pci 1c.1 off end # PCIe port 2 - device pci 1c.2 off end # PCIe port 3 - device pci 1c.3 on end # PCIe port 4 - device pci 1c.4 off end # PCIe port 5 - device pci 1c.5 off end # PCIe port 6 - device pci 1d.0 on end # USB UHCI - device pci 1d.1 on end # USB UHCI - device pci 1d.2 on end # USB UHCI - device pci 1d.3 on end # USB UHCI - device pci 1d.7 on end # USB2 EHCI - device pci 1e.0 on + device pci 1b.0 off end # High Definition Audio + device pci 1c.0 on end # PCIe port 1 + device pci 1c.1 off end # PCIe port 2 + device pci 1c.2 off end # PCIe port 3 + device pci 1c.3 on end # PCIe port 4 + device pci 1c.4 off end # PCIe port 5 + device pci 1c.5 off end # PCIe port 6 + device pci 1d.0 on end # USB UHCI + device pci 1d.1 on end # USB UHCI + device pci 1d.2 on end # USB UHCI + device pci 1d.3 on end # USB UHCI + device pci 1d.7 on end # USB2 EHCI + device pci 1e.0 on # PCI bridge chip southbridge/ti/pci7420 register "smartcard_enabled" = "0x0" device pci 3.0 on end @@ -86,24 +86,24 @@ device pci 3.2 on end device pci 3.3 off end # smartcard end - end # PCI bridge - device pci 1e.2 on end # AC'97 Audio - device pci 1e.3 off end # AC'97 Modem - device pci 1f.0 on # LPC bridge + end + device pci 1e.2 on end # AC'97 Audio + device pci 1e.3 off end # AC'97 Modem + device pci 1f.0 on # LPC bridge chip superio/smsc/lpc47n227 - device pnp 2e.1 on # Parallel port + device pnp 2e.1 on # Parallel port io 0x60 = 0x378 irq 0x70 = 5 end - device pnp 2e.2 on # COM1 + device pnp 2e.2 on # COM1 io 0x60 = 0x3f8 irq 0x70 = 4 end - device pnp 2e.3 on # COM2 + device pnp 2e.3 on # COM2 io 0x60 = 0x2f8 irq 0x70 = 3 end - device pnp 2e.5 off # Keyboard+Mouse + device pnp 2e.5 off # Keyboard+Mouse # io 0x60 = 0x60 # io 0x62 = 0x64 # irq 0x70 = 1 @@ -119,8 +119,8 @@
end device pci 1f.1 off end # IDE - device pci 1f.2 on end # SATA - device pci 1f.3 on end # SMBus + device pci 1f.2 on end # SATA + device pci 1f.3 on end # SMBus end end end
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38072 )
Change subject: mb/roda/rk886ex/devicetree.cb: Align comments ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38072 )
Change subject: mb/roda/rk886ex/devicetree.cb: Align comments ......................................................................
mb/roda/rk886ex/devicetree.cb: Align comments
Change-Id: I67e3149657c04f72aac0b20bc31af338129a13b2 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38072 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/roda/rk886ex/devicetree.cb 1 file changed, 26 insertions(+), 26 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index 5bce304..93a4041 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -29,11 +29,11 @@
device domain 0 on subsystemid 0x4352 0x6886 inherit - device pci 00.0 on end # host bridge + device pci 00.0 on end # host bridge # auto detection: #device pci 01.0 off end # i945 PCIe root port - device pci 02.0 on end # vga controller - device pci 02.1 on end # display controller + device pci 02.0 on end # vga controller + device pci 02.1 on end # display controller
chip southbridge/intel/i82801gx register "pirqa_routing" = "0x0b" @@ -66,19 +66,19 @@ register "gen2_dec" = "0x00fc0601" # ?? register "gen3_dec" = "0x00040069" # EC decode ??
- device pci 1b.0 off end # High Definition Audio - device pci 1c.0 on end # PCIe port 1 - device pci 1c.1 off end # PCIe port 2 - device pci 1c.2 off end # PCIe port 3 - device pci 1c.3 on end # PCIe port 4 - device pci 1c.4 off end # PCIe port 5 - device pci 1c.5 off end # PCIe port 6 - device pci 1d.0 on end # USB UHCI - device pci 1d.1 on end # USB UHCI - device pci 1d.2 on end # USB UHCI - device pci 1d.3 on end # USB UHCI - device pci 1d.7 on end # USB2 EHCI - device pci 1e.0 on + device pci 1b.0 off end # High Definition Audio + device pci 1c.0 on end # PCIe port 1 + device pci 1c.1 off end # PCIe port 2 + device pci 1c.2 off end # PCIe port 3 + device pci 1c.3 on end # PCIe port 4 + device pci 1c.4 off end # PCIe port 5 + device pci 1c.5 off end # PCIe port 6 + device pci 1d.0 on end # USB UHCI + device pci 1d.1 on end # USB UHCI + device pci 1d.2 on end # USB UHCI + device pci 1d.3 on end # USB UHCI + device pci 1d.7 on end # USB2 EHCI + device pci 1e.0 on # PCI bridge chip southbridge/ti/pci7420 register "smartcard_enabled" = "0x0" device pci 3.0 on end @@ -86,24 +86,24 @@ device pci 3.2 on end device pci 3.3 off end # smartcard end - end # PCI bridge - device pci 1e.2 on end # AC'97 Audio - device pci 1e.3 off end # AC'97 Modem - device pci 1f.0 on # LPC bridge + end + device pci 1e.2 on end # AC'97 Audio + device pci 1e.3 off end # AC'97 Modem + device pci 1f.0 on # LPC bridge chip superio/smsc/lpc47n227 - device pnp 2e.1 on # Parallel port + device pnp 2e.1 on # Parallel port io 0x60 = 0x378 irq 0x70 = 5 end - device pnp 2e.2 on # COM1 + device pnp 2e.2 on # COM1 io 0x60 = 0x3f8 irq 0x70 = 4 end - device pnp 2e.3 on # COM2 + device pnp 2e.3 on # COM2 io 0x60 = 0x2f8 irq 0x70 = 3 end - device pnp 2e.5 off # Keyboard+Mouse + device pnp 2e.5 off # Keyboard+Mouse # io 0x60 = 0x60 # io 0x62 = 0x64 # irq 0x70 = 1 @@ -119,8 +119,8 @@
end device pci 1f.1 off end # IDE - device pci 1f.2 on end # SATA - device pci 1f.3 on end # SMBus + device pci 1f.2 on end # SATA + device pci 1f.3 on end # SMBus end end end
-
Angel Pons (Code Review) -
Nico Huber (Code Review)