Change in coreboot[master]: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB

Change-Id: Ia8ef415c36bd915931fcc60231aa624c75bba670
Signed-off-by: Arthur Heymans 
---
M src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
M src/soc/intel/xeon_sp/skx/soc_util.c
2 files changed, 13 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/47295/1

diff --git a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
index cce542a..e0d66d6 100644
--- a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
+++ b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
@@ -14,7 +14,7 @@
 uint8_t get_iiostack_info(struct iiostack_resource *info);

void xeonsp_init_cpu_config(void);
-
+const IIO_UDS *get_iio_uds(void);
 void config_reset_cpl3_csrs(void);

void get_core_thread_bits(uint32_t *core_bits, uint32_t *thread_bits);
diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c
index 3af6483..853846c 100644
--- a/src/soc/intel/xeon_sp/skx/soc_util.c
+++ b/src/soc/intel/xeon_sp/skx/soc_util.c
@@ -46,6 +46,18 @@
  *     +-------------------------+
  */

+const IIO_UDS *get_iio_uds(void)
+{
+	size_t hob_size;
+	static const IIO_UDS *hob;
+	const uint8_t fsp_hob_iio_universal_data_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
+
+	if (hob == NULL)
+		hob = fsp_find_extension_hob_by_guid(fsp_hob_iio_universal_data_guid, &hob_size);
+	assert(hob != NULL && hob_size != 0);
+	return hob;
+}
+
 static uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)
 {
    size_t hob_size;

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47295/1/src/soc/intel/xeon_sp/skx/s... 
File src/soc/intel/xeon_sp/skx/soc_util.c:

https://review.coreboot.org/c/coreboot/+/47295/1/src/soc/intel/xeon_sp/skx/s... 
PS1, Line 56: 		hob = fsp_find_extension_hob_by_guid(fsp_hob_iio_universal_data_guid, &hob_size);
line over 96 characters

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Patch Set 1:

No need for this patch now that the function was moved to xeon_sp/util.c in CB:47170.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Patch Set 1:
> Patch Set 1:
>
> No need for this patch now that the function was moved to xeon_sp/util.c in CB:47170.

Ok. I'll remove this in a rebase. Thanks

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Patch Set 1:

Can we merge this function to not have duplicate copies in cpx and in skx?

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Abandoned

Is moved to soc/intel/xeon_sp

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47295 )

Change subject: soc/intel/xeon_sp/skx: Copy the cpx function to get the IIO HOB
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Can we merge this function to not have duplicate copies in cpx and in skx?

I rebased this on master where this already done.