Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79099?usp=email )
Change subject: acpi: Optimize enum acpi_tables layout ......................................................................
acpi: Optimize enum acpi_tables layout
Arrange ACPI table enum in a vertical and alphabetized format. This change aims to reduce conflicts between patches.
Change-Id: I192339df771d6a3ae67358fe46334fe2b216b974 Signed-off-by: Naresh Solanki naresh.solanki@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/79099 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/acpi/acpi.h 1 file changed, 32 insertions(+), 5 deletions(-)
Approvals: Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index fe7e5fd..9a9a66d 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -75,12 +75,39 @@ };
enum acpi_tables { - /* Tables defined by ACPI and used by coreboot */ - BERT, CEDT, DBG2, DMAR, DSDT, EINJ, FACS, FADT, HEST, HMAT, HPET, IVRS, - MADT, MCFG, RSDP, RSDT, SLIT, SRAT, SSDT, TCPA, TPM2, XSDT, ECDT, LPIT, - SPCR, GTDT, + /* Alphabetic list of Tables defined by ACPI and used by coreboot */ + BERT, /* Boot Error Record Table */ + CEDT, /* CXL Early Discovery Table */ + DBG2, /* Debug Port Table 2 */ + DMAR, /* DMA Remapping Table */ + DSDT, /* Differentiated System Description Table */ + ECDT, /* Embedded Controller Boot Resources Table */ + EINJ, /* Error Injection Table */ + FACS, /* Firmware ACPI Control Structure */ + FADT, /* Fixed ACPI Description Table */ + GTDT, /* Generic Timer Description Table */ + HEST, /* Hardware Error Source Table */ + HMAT, /* Heterogeneous Memory Attribute Table */ + HPET, /* High Precision Event Timer Table */ + IVRS, /* I/O Virtualization Reporting Structure */ + LPIT, /* Low Power Idle Table */ + MADT, /* Multiple APIC Description Table */ + MCFG, /* PCI Express Memory Mapped Configuration */ + RSDP, /* Root System Description Pointer */ + RSDT, /* Root System Description Table */ + SLIT, /* System Locality Distance Information Table */ + SPCR, /* Serial Port Console Redirection Table */ + SRAT, /* System Resource Affinity Table */ + SSDT, /* Secondary System Description Table */ + TCPA, /* Trusted Computing Platform Alliance Table */ + TPM2, /* Trusted Platform Module 2.0 Table */ + XSDT, /* Extended System Description Table */ + /* Additional proprietary tables used by coreboot */ - VFCT, NHLT, SPMI, CRAT + CRAT, /* Component Resource Attribute Table */ + NHLT, /* Non HD audio Link Table */ + SPMI, /* Server Platform Management Interface table */ + VFCT /* VBIOS Fetch Table */ };
/* RSDP (Root System Description Pointer) */