Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: wifi: Add support for new SAR tables revisions
......................................................................
Patch Set 22:
(1 comment)
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/ed610ff5_fbe17388
PS22, Line 142: LEGACY_SAR_BIN_SIZE
The filesize will always be 119, based on the CONFIG_GEO_SAR_ENABLE, it will decide how many bytes t […]
The problem is that the cros_config_proto_converter isn't used by any platforms yet. So, partners have been generating the files manually. Because of that the boards that do not enable CONFIG_GEO_SAR_ENABLE will have a smaller file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Gerrit-Change-Number: 56750
Gerrit-PatchSet: 22
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 30 Aug 2021 00:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment