Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28752 )
Change subject: src: Move common IA-32 MSRs to <cpu/x86/msr.h>
......................................................................
Patch Set 13:
(3 comments)
File src/cpu/intel/model_6fx/model_6fx_init.c:
https://review.coreboot.org/c/coreboot/+/28752/comment/aac6ebf0_b89352fe
PS2, Line 62: #define IA32_PECI_CTL 0x5a0
This MSR is not documented, so I don't know if it is specific to 6fx or not.
Done
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/28752/comment/d97f9db1_79318543
PS11, Line 25: #define IA32_BIOS_UPDT_TRIG 0x79
: #define IA32_BIOS_SIGN_ID 0x8b
sounds good to me.
Ack
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/28752/comment/99aa5b31_f2affafd
PS2, Line 126: #endif
Done
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida7f2d608c55796abf9452f190a58802e498302d
Gerrit-Change-Number: 28752
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 14 Nov 2022 11:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment