Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@9 PS5, Line 9: From JSL FSP v2376 "FirmwareVersionInfo.h" header file is : added and "FirmwareVersionInfoHob.h" is removed. Please describe, what the benefits of that new header are. Also, why do the FSP developers introduce such a difficult to integrate change?
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@11 PS5, Line 11: include included
https://review.coreboot.org/c/coreboot/+/45905/5//COMMIT_MSG@17 PS5, Line 17: TEST=Verify JSLRVP build Please paste the output with the new header file.
https://review.coreboot.org/c/coreboot/+/45905/5/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig.debug_blob:
https://review.coreboot.org/c/coreboot/+/45905/5/src/drivers/intel/fsp2_0/Kc... PS5, Line 46: using new header 'FirmwareVersionInfo.h'. Can’t this be better integrated?
When was the header introduced? Can it be deduced from the FSP version?
-
Paul Menzel (Code Review)