Change in ...coreboot[master]: util/kconfig: Fix missing library issue with ld 2.24 and newer

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32137

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

util/kconfig: Fix missing library issue with ld 2.24 and newer

When invoking 'make menuconfig' with gcc 4.9.2 an error is thrown:

ld: build/util/kconfig/lxdialog/checklist.o: undefined reference
to symbol 'acs_map'

This happens with ld version 2.24 and newer when menuconfig is
executed for the first time after make clean. This does not happen
with ld 2.20 (part of gcc 4.4.7).
It can be fixed with the flag -ltinfo in HOST_LOADLIBES.

Change-Id: I6216bb4d276d4bf98aa4ec06457b809fdcd73235
Signed-off-by: Werner Zeh 
---
M util/kconfig/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32137/1

diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile
index a79229d..bf9db64 100644
--- a/util/kconfig/Makefile
+++ b/util/kconfig/Makefile
@@ -133,7 +133,7 @@
 # we really need to do so. (Do not call gcc as part of make mrproper)
 HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \
                     -DLOCALE
-HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
+HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) -ltinfo

# ===========================================================================

[Werner Zeh (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32137

to look at the new patch set (#2).

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

util/kconfig: Fix missing library issue with ld 2.24 and newer

When invoking 'make menuconfig' with gcc 4.9.2 an error is thrown:

ld: build/util/kconfig/lxdialog/checklist.o: undefined reference
to symbol 'acs_map'

This happens with ld version 2.24 and newer when menuconfig is
executed for the first time after make clean. This does not happen
with ld 2.20 (part of gcc 4.4.7).
It can be fixed with the flag -ltinfo in HOST_LOADLIBES.

Change-Id: I6216bb4d276d4bf98aa4ec06457b809fdcd73235
Signed-off-by: Werner Zeh 
---
M util/kconfig/Makefile
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32137/2

[Werner Zeh (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32137

to look at the new patch set (#3).

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

util/kconfig: Fix missing library issue with ld 2.24 and newer

When invoking 'make menuconfig' with gcc 4.9.2 an error is thrown:

ld: build/util/kconfig/lxdialog/checklist.o: undefined reference
to symbol 'acs_map'

This happens with ld version 2.24 and newer when menuconfig is
executed for the first time after make clean. This does not happen
with ld 2.20 (part of gcc 4.4.7).
It can be fixed with the flag -ltinfo in HOST_LOADLIBES.

Change-Id: I6216bb4d276d4bf98aa4ec06457b809fdcd73235
Signed-off-by: Werner Zeh 
---
M util/kconfig/Makefile
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32137/3

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32137 )

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

Patch Set 3: Code-Review+2

Looks reasonable. If this breaks on some system, we can refine it once we have a test case.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32137 )

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

Patch Set 3:

(1 comment)

So you recently updated your build environment to ld 2.24 and experienced this issue?

https://review.coreboot.org/#/c/32137/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32137/3//COMMIT_MSG@17 
PS3, Line 17: It can be fixed with the flag -ltinfo in HOST_LOADLIBES.
Please add a blank line above.

[Werner Zeh (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32137

to look at the new patch set (#4).

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

util/kconfig: Fix missing library issue with ld 2.24 and newer

When invoking 'make menuconfig' with gcc 4.9.2 an error is thrown:

ld: build/util/kconfig/lxdialog/checklist.o: undefined reference
to symbol 'acs_map'

This happens with ld version 2.24 and newer when menuconfig is
executed for the first time after make clean. This does not happen
with ld 2.20 (part of gcc 4.4.7).

It can be fixed with the flag -ltinfo in HOST_LOADLIBES.

Change-Id: I6216bb4d276d4bf98aa4ec06457b809fdcd73235
Signed-off-by: Werner Zeh 
---
M util/kconfig/Makefile
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32137/4

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32137 )

Change subject: util/kconfig: Fix missing library issue with ld 2.24 and newer
......................................................................

util/kconfig: Fix missing library issue with ld 2.24 and newer

When invoking 'make menuconfig' with gcc 4.9.2 an error is thrown:

ld: build/util/kconfig/lxdialog/checklist.o: undefined reference
to symbol 'acs_map'

This happens with ld version 2.24 and newer when menuconfig is
executed for the first time after make clean. This does not happen
with ld 2.20 (part of gcc 4.4.7).

It can be fixed with the flag -ltinfo in HOST_LOADLIBES.

Change-Id: I6216bb4d276d4bf98aa4ec06457b809fdcd73235
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32137
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M util/kconfig/Makefile
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/util/kconfig/Makefile b/util/kconfig/Makefile
index a79229d..147b125 100644
--- a/util/kconfig/Makefile
+++ b/util/kconfig/Makefile
@@ -133,7 +133,8 @@
 # we really need to do so. (Do not call gcc as part of make mrproper)
 HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \
                     -DLOCALE
-HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
+HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) \
+                    -ldflags $(HOSTCC)) -ltinfo

# ===========================================================================