Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/29480/3/src/mainboard/kontron/bsl6/... File src/mainboard/kontron/bsl6/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/29480/3/src/mainboard/kontron/bsl6/... PS3, Line 22: "COREv4", // OEM id : "COREBOOT", // OEM table id
These should be replaced with the macros in arch/acpi. […]
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/gpio.h:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 24: #define GPIO_SPEAKER_MAXIM_AMP_SDMODE GPP_B2
Seems copied off some Google board
Done
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... File src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/29480/11/src/mainboard/kontron/bsl6... PS11, Line 104: register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" # I2C4 is 1.8V
Seems copied off some Google board
Done
-
Felix Singer (Code Review)