Attention is currently required from: Malik Hsu. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55404 )
Change subject: mb/google/brya/variants/primus: set up gpio ......................................................................
Patch Set 2: Code-Review+2
(8 comments)
File src/mainboard/google/brya/variants/primus/gpio.c:
https://review.coreboot.org/c/coreboot/+/55404/comment/b0d8a0e0_6f917801 PS1, Line 24:
These two pins were originally connected to the i219 LAN chip, but the LAN function has been removed […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/22e53728_c48fa0dd PS1, Line 24:
These two pins were originally connected to the i219 LAN chip, but the LAN function has been removed […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/fee456b3_670e8fc8 PS1, Line 29: /* D6 : SRCCLKREQ1# ==> WWAN_SIM1_DET_ODL */
Yes，this pin is NC. […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/80ad61d1_b8bed00c PS1, Line 29: /* D6 : SRCCLKREQ1# ==> WWAN_SIM1_DET_ODL */
Yes，this pin is NC. […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/8e2b33a1_c1fca2f7 PS1, Line 40:
Done. […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/be8a88fd_03934736 PS1, Line 40:
Done. […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/56ce1ffd_0dfb9d96 PS1, Line 50:
Done. […]
Ack
https://review.coreboot.org/c/coreboot/+/55404/comment/054a78d4_ec9b17a8 PS1, Line 50:
Done. […]
Ack
-
Tim Wawrzynczak (Code Review)