Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45322 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h ......................................................................
soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h
Removed unused header files in chip.h
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Idb9b1ed23df3dbb9dad4d36651064c21a4d913fc --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/icelake/chip.h M src/soc/intel/jasperlake/chip.h M src/soc/intel/tigerlake/chip.h 4 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45322/1
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 9e7aa45..6a083c6 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -10,7 +10,6 @@ #include <intelblocks/lpc_lib.h> #include <intelblocks/power_limit.h> #include <stdint.h> -#include <soc/gpio.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pm.h> diff --git a/src/soc/intel/icelake/chip.h b/src/soc/intel/icelake/chip.h index 2b190cd..d60791b 100644 --- a/src/soc/intel/icelake/chip.h +++ b/src/soc/intel/icelake/chip.h @@ -9,7 +9,6 @@ #include <intelblocks/gspi.h> #include <stdint.h> #include <soc/gpe.h> -#include <soc/gpio.h> #include <soc/pch.h> #include <soc/gpio_defs.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/chip.h b/src/soc/intel/jasperlake/chip.h index 70fbbc3..3f0b910 100644 --- a/src/soc/intel/jasperlake/chip.h +++ b/src/soc/intel/jasperlake/chip.h @@ -9,8 +9,6 @@ #include <intelblocks/gspi.h> #include <intelblocks/power_limit.h> #include <soc/gpe.h> -#include <soc/gpio.h> -#include <soc/gpio_defs.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pmc.h> diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h index 2da63ed..dc8697b 100644 --- a/src/soc/intel/tigerlake/chip.h +++ b/src/soc/intel/tigerlake/chip.h @@ -9,8 +9,6 @@ #include <intelblocks/gspi.h> #include <intelblocks/power_limit.h> #include <soc/gpe.h> -#include <soc/gpio.h> -#include <soc/gpio_defs.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pmc.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45322 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45322 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45322 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h ......................................................................
soc/intel/{cnl,icl,jsl,tgl}: Clean up chip.h
Removed unused header files in chip.h
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Idb9b1ed23df3dbb9dad4d36651064c21a4d913fc Reviewed-on: https://review.coreboot.org/c/coreboot/+/45322 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/icelake/chip.h M src/soc/intel/jasperlake/chip.h M src/soc/intel/tigerlake/chip.h 4 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 9e7aa45..6a083c6 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -10,7 +10,6 @@ #include <intelblocks/lpc_lib.h> #include <intelblocks/power_limit.h> #include <stdint.h> -#include <soc/gpio.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pm.h> diff --git a/src/soc/intel/icelake/chip.h b/src/soc/intel/icelake/chip.h index 2b190cd..d60791b 100644 --- a/src/soc/intel/icelake/chip.h +++ b/src/soc/intel/icelake/chip.h @@ -9,7 +9,6 @@ #include <intelblocks/gspi.h> #include <stdint.h> #include <soc/gpe.h> -#include <soc/gpio.h> #include <soc/pch.h> #include <soc/gpio_defs.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/chip.h b/src/soc/intel/jasperlake/chip.h index 70fbbc3..3f0b910 100644 --- a/src/soc/intel/jasperlake/chip.h +++ b/src/soc/intel/jasperlake/chip.h @@ -9,8 +9,6 @@ #include <intelblocks/gspi.h> #include <intelblocks/power_limit.h> #include <soc/gpe.h> -#include <soc/gpio.h> -#include <soc/gpio_defs.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pmc.h> diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h index 2da63ed..dc8697b 100644 --- a/src/soc/intel/tigerlake/chip.h +++ b/src/soc/intel/tigerlake/chip.h @@ -9,8 +9,6 @@ #include <intelblocks/gspi.h> #include <intelblocks/power_limit.h> #include <soc/gpe.h> -#include <soc/gpio.h> -#include <soc/gpio_defs.h> #include <soc/pch.h> #include <soc/pci_devs.h> #include <soc/pmc.h>
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Subrata Banik (Code Review)