Attention is currently required from: Martin Roth, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51090 )
Change subject: [WIP] mb/hp: Add HP ProBook 6550b ......................................................................
Patch Set 3: Verified+1
(17 comments)
File src/mainboard/hp/probook_6550b/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/8fbba4bb_1c1c1a47 PS3, Line 17: /* 00 */ 0x82, 0xfd, 0x00, 0x00, 0xf4, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/834cca7f_21f8e1cd PS3, Line 18: /* 10 */ 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x10, 0x02, 0x45, 0x01, 0x02, 0x32, 0xe4, 0x0f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/4db49200_03358477 PS3, Line 19: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/3b32e3fb_f1abc2ee PS3, Line 20: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/7c2a7626_223f02b4 PS3, Line 21: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/a894269a_96a3553d PS3, Line 22: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/fdf9b015_ca6e32e9 PS3, Line 23: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/0a424f26_b79df8db PS3, Line 24: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/5b584f14_faca1de1 PS3, Line 25: /* 80 */ 0x00, 0x00, 0x04, 0x01, 0x01, 0x01, 0x00, 0x14, 0x0f, 0x01, 0x00, 0xff, 0xff, 0x01, 0x00, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/9be540df_b97f42fb PS3, Line 26: /* 90 */ 0xff, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/a8ee1b15_002260f5 PS3, Line 27: /* a0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xc8, 0x00, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/545833ca_6add67a8 PS3, Line 28: /* b0 */ 0xff, 0x96, 0x00, 0xff, 0xff, 0x64, 0xff, 0x00, 0x00, 0x64, 0x5a, 0x00, 0x41, 0x00, 0xff, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/a6c484da_ae5f9121 PS3, Line 29: /* c0 */ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xaa, 0xaa, 0xff, 0xff, 0x3f, 0x28, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/9466c5bc_5446f2ef PS3, Line 30: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x1e, 0x1e, 0x02, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/f3f4b786_74379d65 PS3, Line 31: /* e0 */ 0x74, 0x0b, 0xff, 0x07, 0x00, 0xf4, 0x00, 0x00, 0x03, 0x00, 0x04, 0x00, 0xff, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/b50a8fbd_b8250b95 PS3, Line 32: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145304): https://review.coreboot.org/c/coreboot/+/51090/comment/5a2211cd_caae6737 PS3, Line 37: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('
-
build bot (Jenkins) (Code Review)