Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Why do this conversion at runtime and not at buildtime?
1, the conversion logic doesn't even 1ms hence, there is no harm in doing runtime
2. passing BMP image as compressed in more beneficial in SPI size than passing the data structure that holds BLT buffer
3. There may be the need to keep multiple logo file into the CBFS and load only one based on the SKU ID/type, hence, runtime conversion is more logical rather keeping multiple static data structure converted and stored into cbfs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76921?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I992b45d65374f09498ff0cab497f7091e1e7a350
Gerrit-Change-Number: 76921
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 14 Aug 2023 18:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment