Change in coreboot[master]: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table....
Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate ......................................................................
[TEST-ONLY]Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/1
diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c index 886e14f..1b33b03 100644 --- a/src/mainboard/google/kahlee/OemCustomize.c +++ b/src/mainboard/google/kahlee/OemCustomize.c @@ -39,7 +39,7 @@ PSO_END }; /* Liara-specific 2T memory configuration */ -static const PSO_ENTRY DDR4LiaraMemoryConfiguration[] = { +static const PSO_ENTRY DDR4_T2_MemoryConfiguration[] = { DRAM_TECHNOLOGY(ANY_SOCKET, DDR4_TECHNOLOGY), NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, DIMMS_PER_CHANNEL), NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, MAX_DRAM_CH), @@ -58,9 +58,9 @@
void OemPostParams(AMD_POST_PARAMS *PostParams) { - if (CONFIG(BOARD_GOOGLE_LIARA)) + if (CONFIG(BOARD_GOOGLE_LIARA) || CONFIG(BOARD_GOOGLE_TREEYA)) PostParams->MemConfig.PlatformMemoryConfiguration = - (PSO_ENTRY *)DDR4LiaraMemoryConfiguration; + (PSO_ENTRY *)DDR4_T2_MemoryConfiguration; else PostParams->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)DDR4PlatformMemoryConfiguration;
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#2).
Change subject: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate ......................................................................
[TEST-ONLY]Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35116/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35116/2//COMMIT_MSG@7 PS2, Line 7: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table. The commit message summary should be one line followed by a blank line.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#3).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table. Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/3
Hello chris wang, Justin TerAvest, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#4).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table
Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/4
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35116/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35116/2//COMMIT_MSG@7 PS2, Line 7: [TEST-ONLY]Update the memory timing table for Treeya to the 2T table.
The commit message summary should be one line followed by a blank line.
Done
Peichao Li has removed Justin TerAvest from this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Removed reviewer Justin TerAvest.
Peichao Li has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Removed reviewer Martin Roth.
Peichao Li has removed chris wang from this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Removed reviewer chris wang.
Peichao Li has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Removed reviewer Paul Menzel.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#5).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table
Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/5
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#6).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table Rename the table from Liara specific to simply specifying that it's using 2T command rate ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/6
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#7).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table
Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/7
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... PS7, Line 42: T2 could we use 2T instead?
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... PS7, Line 63: T2_ the same as above.
Hello chris wang, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35116
to look at the new patch set (#8).
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table
Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35116/8
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... PS7, Line 42: T2
could we use 2T instead?
Done
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... PS7, Line 63: T2_
the same as above.
Done
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Patch Set 8: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/35116/7/src/mainboard/google/kahlee... PS7, Line 41: Liara-specific Nit: You might want to remove this now that it's not Liara specific.
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35116 )
Change subject: mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table ......................................................................
mb/google/kahlee/treeya: Update the memory timing table for Treeya to the 2T table
Rename the table from Liara specific to simply specifying that it's using 2T command rate
BUG=139841929 TEST=build and do stress test
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6e10b95c8aea50e68d8a3b710f30dda4f6b807d3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35116 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/OemCustomize.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/OemCustomize.c b/src/mainboard/google/kahlee/OemCustomize.c index 886e14f..8e5d8eb 100644 --- a/src/mainboard/google/kahlee/OemCustomize.c +++ b/src/mainboard/google/kahlee/OemCustomize.c @@ -39,7 +39,7 @@ PSO_END }; /* Liara-specific 2T memory configuration */ -static const PSO_ENTRY DDR4LiaraMemoryConfiguration[] = { +static const PSO_ENTRY DDR4_2T_MemoryConfiguration[] = { DRAM_TECHNOLOGY(ANY_SOCKET, DDR4_TECHNOLOGY), NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, DIMMS_PER_CHANNEL), NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, MAX_DRAM_CH), @@ -58,9 +58,9 @@
void OemPostParams(AMD_POST_PARAMS *PostParams) { - if (CONFIG(BOARD_GOOGLE_LIARA)) + if (CONFIG(BOARD_GOOGLE_LIARA) || CONFIG(BOARD_GOOGLE_TREEYA)) PostParams->MemConfig.PlatformMemoryConfiguration = - (PSO_ENTRY *)DDR4LiaraMemoryConfiguration; + (PSO_ENTRY *)DDR4_2T_MemoryConfiguration; else PostParams->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *)DDR4PlatformMemoryConfiguration;
-
chris wang (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)