Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge.
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index 95274eb..30fcc8c 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -15,6 +15,7 @@
#include <ec/google/chromeec/ec.h> #include <baseboard/variants.h> +#include <boardid.h> #include <cbfs.h> #include <gpio.h> #include <smbios.h> @@ -24,7 +25,7 @@ #include <device/pci_ops.h> #include <drivers/generic/bayhub/bh720.h>
-uint8_t variant_board_sku(void) +uint32_t sku_id(void) { static int sku = -1;
@@ -34,6 +35,11 @@ return sku; }
+uint8_t variant_board_sku(void) +{ + return sku_id(); +} + void variant_mainboard_suspend_resume(void) { /* Enable backlight - GPIO 133 active low */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... PS1, Line 28: sku_id I wonder if we should update ec_boardid.c (https://review.coreboot.org/cgit/coreboot.git/tree/src/ec/google/chromeec/ec...) to add support for a sku_id() implementation for chromeec. Then, it wouldn't have to be duplicated across multiple mainboards.
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#2).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/ec/google/chromeec/ec_boardid.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku; please, no spaces at the start of a line
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#3).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/ec/google/chromeec/ec_boardid.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 33: MAYBE_STATIC_NONZERO uint32_t sku = -1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 35: if (sku == -1)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 36: sku = google_chromeec_get_sku_id();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/2/src/ec/google/chromeec/ec_b... PS2, Line 38: return sku;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/1/src/mainboard/google/kahlee... PS1, Line 28: sku_id
I wonder if we should update ec_boardid.c (https://review.coreboot.org/cgit/coreboot. […]
Done
Magf - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... PS3, Line 31: uint32_t sku_id(void) Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without CBI (maybe still other factors), put this function here will lead to compile conflicts and wrong output. If wanting to refactor this, need consider all of them. So I still suggest to do this thing in kahlee baseboard for treeya project.
Magf - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... PS3, Line 31: uint32_t sku_id(void)
Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without C […]
Maybe another method, remove weak implementation in coreboot_table.c, make this one __weak.
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#4).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/ec/google/chromeec/ec_boardid.c M src/lib/coreboot_table.c 2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/4
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... PS4, Line 31: sku_id Mark __weak flag here and make sure this sku_id function is default.
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c@a2... PS4, Line 227: 1. I thought that need remove sku_id here, make sure no other side effects. 2. default sku_id function move to ec_boardid.c
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#5).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/mainboard/google/kahlee/variants/treeya/Makefile.inc A src/mainboard/google/kahlee/variants/treeya/mainboard.c 2 files changed, 115 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/5
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 4:
Patchset 1 is make sense, I think we can create a separate mainboard.c for treeya and implement it.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku; please, no spaces at the start of a line
Hello Justin TerAvest, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#6).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/mainboard/google/kahlee/variants/treeya/Makefile.inc A src/mainboard/google/kahlee/variants/treeya/mainboard.c 2 files changed, 116 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/6
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku;
code indent should use tabs where possible
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... PS3, Line 31: uint32_t sku_id(void)
Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without CBI (maybe still other factors), put this function here will lead to compile conflicts and wrong output.
Ah I see. Yeah, I think its best to do the refactoring out of the scope of this CL. Thanks for checking.
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#7).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/7
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 6:
Patch Set 6:
(1 comment)
So I think we can back to patchset 1.
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35214
to look at the new patch set (#8).
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35214/8
Magf - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 8: Code-Review+1
Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 8: Code-Review+2
I think this is ok to unblock treeya, but I agree with Furquan that it would be good to have a common sku_id() implementation, and refactor somehow to avoid having both "__weak uint32_t sku_id()" and "uint8_t __weak variant_board_sku()".
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 8: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b... PS3, Line 31: uint32_t sku_id(void)
Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without […]
Patch updated.
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/ec/google/chromeec/ec_b... PS4, Line 31: sku_id
Mark __weak flag here and make sure this sku_id function is default.
Patch changed.
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35214/4/src/lib/coreboot_table.c@a2... PS4, Line 227:
- I thought that need remove sku_id here, make sure no other side effects. […]
Patch changed.
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
mb/google/kahlee/treeya: override sku_id() function
override 'uint32_t sku_id(void)' so that lib_sysinfo.sku_id get a correct value in depthcharge
BUG=b:140010592 BRANCH=none TEST=boot treeya board, in depthcharge stage, lib_sysinfo.sku_id print correct value.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I631f62021e8104a69a43667a811c9c23e3105596 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35214 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Magf - magf@bitland.corp-partner.google.com Reviewed-by: Edward Hill ecgh@chromium.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Edward Hill: Looks good to me, approved Magf -: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index 95274eb..30fcc8c 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -15,6 +15,7 @@
#include <ec/google/chromeec/ec.h> #include <baseboard/variants.h> +#include <boardid.h> #include <cbfs.h> #include <gpio.h> #include <smbios.h> @@ -24,7 +25,7 @@ #include <device/pci_ops.h> #include <drivers/generic/bayhub/bh720.h>
-uint8_t variant_board_sku(void) +uint32_t sku_id(void) { static int sku = -1;
@@ -34,6 +35,11 @@ return sku; }
+uint8_t variant_board_sku(void) +{ + return sku_id(); +} + void variant_mainboard_suspend_resume(void) { /* Enable backlight - GPIO 133 active low */
-
build bot (Jenkins) (Code Review) -
Edward Hill (Code Review)
-
Furquan Shaikh (Code Review)
-
Magf - (Code Review)
-
Martin Roth (Code Review)
-
Peichao Li (Code Review)