Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54952 )
Change subject: ec/kontron/kempld: Guard macro parameters ......................................................................
ec/kontron/kempld: Guard macro parameters
Add parentheses around macro parameters to avoid operation order issues.
Change-Id: I2d4552abaeda5702619cc53e9dfae1f17b048e67 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54952 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/kontron/kempld/kempld_internal.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/ec/kontron/kempld/kempld_internal.h b/src/ec/kontron/kempld/kempld_internal.h index 014778c..993fe8e 100644 --- a/src/ec/kontron/kempld/kempld_internal.h +++ b/src/ec/kontron/kempld/kempld_internal.h @@ -12,8 +12,8 @@
/* indexed registers */ #define KEMPLD_SPEC 0x06 -#define KEMPLD_SPEC_GET_MINOR(x) (x & 0x0f) -#define KEMPLD_SPEC_GET_MAJOR(x) (x >> 4 & 0x0f) +#define KEMPLD_SPEC_GET_MINOR(x) ((x) & 0x0f) +#define KEMPLD_SPEC_GET_MAJOR(x) ((x) >> 4 & 0x0f)
#define KEMPLD_CFG 0x37 #define KEMPLD_CFG_GPIO_I2C_MUX (1 << 0)