Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................
Patch Set 38:
Patch Set 36:
I do understand the process in this change. Let me elaborate
my theory more accurately. You can have a RO FIT with entries
to both RO MCU and RW MCU (at least that is what I understood
earlier). Booting with the process of this change and top-swap
disabled should have the same effect as booting with such a
two-entry FIT and erased RW MCU. Right?
It's a design goal in Chromebooks that stuff like recovery mode remains predictable (ie. rely on read-only data _only_), while still allowing features like dev mode. (There's also the option of disabling write protect, but that's a whole different story.)
The top-swap solution provides this feature under these constraints even for FIT-based ucode updates. Your proposal requires erasing a block in RW even though it might not be "ours" anymore, but managed by the device owner (eg. in dev mode).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 38
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Dhaval Sharma
dhaval.v.sharma@intel.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 16 Jan 2019 13:36:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment