Attention is currently required from: Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87087?usp=email )
Change subject: mb/google/fatcat: Increase sagv_freq_mhz for work point #1 and #3
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/87087/comment/2a3e80b2_fd7b611f?usp... :
PS5, Line 42: 6000
While reviewing this CL, I synced up with the PnP (Power aNd Performance) team. The recommendation I got is:
- SAGV[0] = 2400
- SAGV[1] = 4800
- SAGV[2] = 6400
- SAGV[3] = 6800
Your change misses the SAGV[2] update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87087?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id0b25adeed4b3f3e1c37d17901006a2db2d21223
Gerrit-Change-Number: 87087
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Thu, 03 Apr 2025 20:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes