Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 )
Change subject: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STORAGE_HOB2 HOB introduced in FSP 2.3
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/intel/fsp2_0/hand_off_block.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134724):
https://review.coreboot.org/c/coreboot/+/59638/comment/7c719866_111a89e8
PS14, Line 322: fsp_find_extension_hob_by_guid (fsp_nv_storage_guid_2, size);
space prohibited between function name and open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e
Gerrit-Change-Number: 59638
Gerrit-PatchSet: 14
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 01 Dec 2021 05:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment