Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58930 )
Change subject: mb/google/brya/var/felwinter: Correct typeC EC mux port
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/felwinter/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58930/comment/32bcee13_41a739f6
PS2, Line 126: #TBD, felwinter remove typeC port0
: chip ec/google/chromeec
: use conn1 as mux_conn[1]
: use conn2 as mux_conn[0]
stale comment? also should they be ordered by conn or by mux_conn? e..g […]
This is tricky, conn2=MB port2 is correct but EC mux is 0. Ordered by conn is fine, for AP side, MB port is primary :p
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85218c81018b248c41a2cdaf9360a86e2a7d4d7a
Gerrit-Change-Number: 58930
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment