Attention is currently required from: Jeff Daly, Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Paul Menzel, Vanessa Eusebio, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63788 )
Change subject: cpu/intel/*: Set SMM SMRR code access check bit
......................................................................
Patch Set 4:
(3 comments)
File src/include/cpu/intel/smm_reloc.h:
https://review.coreboot.org/c/coreboot/+/63788/comment/56805718_bcf95add
PS4, Line 102: SMM_CODE_ACESSS_CHK_MASK
also in case bit 58 is not set, do we expected to alert the user ?
https://review.coreboot.org/c/coreboot/+/63788/comment/f1f424c7_9397aa4e
PS4, Line 105: }
still need the wrmsr(smm_feature) here
you missed wrmsr looks like
File src/soc/intel/denverton_ns/smihandler.c:
https://review.coreboot.org/c/coreboot/+/63788/comment/fe8c2502_b6a3d553
PS4, Line 6: #include <cpu/intel/em64t100_save_state.h>
: #include <cpu/intel/smm_reloc.h>
can u also capture the order change in commit msg as well ? or prefer to do in incremental CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7
Gerrit-Change-Number: 63788
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 23 Apr 2022 07:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment