Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Andrey Petrov, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69090 )
Change subject: drivers/intel/fsp2_0/include/fsp: accomodate xeon_sp FSPX_CONFIG definitions
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/xeon_sp/cpx/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69090/comment/ade05bc7_b74149a8
PS1, Line 19: CPPFLAGS_common += -i
You now need to include soc_binding.h in the right files 'above' other header files. Because needing an explicit order in header files is painful (and sometimes not possible if it's common code) a CPP flag is easier to deal with.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa0e1efa1618fbec84f1e1f23d9e49f3b1057b32
Gerrit-Change-Number: 69090
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 07:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment