Attention is currently required from: Paul Menzel, Paz Zcharya, Subrata Banik.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email )
Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ......................................................................
Patch Set 7:
(2 comments)
File src/vendorcode/google/chromeos/tpm_factory_config.c:
https://review.coreboot.org/c/coreboot/+/80738/comment/d206f026_13b60297 : PS7, Line 74: * requirement.
I assume the design doc is at `go/cros-tiering-dd`. […]
Requested comment access to the doc. If there are corner cases, then line 97 is incorrect.
https://review.coreboot.org/c/coreboot/+/80738/comment/9d828eaa_a179bf86 : PS7, Line 104: return strncmp(vpd_get_feature_device_info(), "CAI", 3) == 0;
The previous comment states "all older devices will have legacy config", so we don't need the non- […]
| Regular Chromebook device
Assuming this change applies to devices built after 2/23 (as documented in comment for line 97), all hardware compliant chromebook will have the proper bit set in GSC, so the VPD logic is not needed.