Attention is currently required from: Philip Chen, zanxi chen, Julius Werner, Bob Moragues.
Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 )
Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I am not sure that this is the correct way to handle this.
I believe these panels should be configured in the SKU table using the available bits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2
Gerrit-Change-Number: 57329
Gerrit-PatchSet: 4
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bob Moragues
moragues@google.com
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: Wenli Xu
xuwenli@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Philip Chen
philipchen@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Thu, 02 Sep 2021 22:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment