Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/#/c/30414/19/src/mainboard/facebook/fbg1701/Kcon...
File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/#/c/30414/19/src/mainboard/facebook/fbg1701/Kcon...
PS19, Line 31: choice
Use GENERIC_SPD_BIN and please refer to my comments in Portwell mainboard patch. I have explained how to switch between SPDs.
https://review.coreboot.org/#/c/30414/19/src/mainboard/facebook/fbg1701/Make...
File src/mainboard/facebook/fbg1701/Makefile.inc:
https://review.coreboot.org/#/c/30414/19/src/mainboard/facebook/fbg1701/Make...
PS19, Line 44: SPD_SOURCES += MICRON_MT41K512M16HA-125A
no SPD file for MICRON present in the patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 19
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Wed, 17 Apr 2019 12:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment