Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76169?usp=email )
Change subject: mb/google/rex/var/screebo:Fix touchpad timing
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76169/comment/80c175ad_68d3dfbc :
PS3, Line 9: Change i2c[3]: t-HIGH > 600ns;Frequency < 400kHZ;900ns > Thd:dat > 300ns.
maybe?
Change i2c[3] parameter to met below timing.
t-HIGH > 600ns
Frequency < 400kHZ
900ns > Thd:dat > 300ns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b2d958a5a0d41e2cfa1087f5cb94cc83bbb1739
Gerrit-Change-Number: 76169
Gerrit-PatchSet: 3
Gerrit-Owner: zhongtian wu
wuzhongtian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: zhongtian wu
wuzhongtian@huaqin.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 03 Jul 2023 05:49:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment