Attention is currently required from: Ravi kumar, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52131 )
Change subject: sc7280: Enable bootblock compression
......................................................................
Patch Set 28:
(1 comment)
File src/soc/qualcomm/sc7280/Kconfig:
https://review.coreboot.org/c/coreboot/+/52131/comment/be63f494_c07d89bb
PS14, Line 16: select HAVE_UART_SPECIAL
: select BOOTBLOCK_CONSOLE
these don't seem to be related to the compression of the bootblock. Are they necessary for this CL or were they just left out before? If they're unrelated, I'd prefer if they were either explicitly called out in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3564a7e531d769c8df16a1592ea98133d83b07b0
Gerrit-Change-Number: 52131
Gerrit-PatchSet: 28
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 12 Jul 2021 22:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment