Attention is currently required from: Sumeet Pawnikar, Furquan Shaikh, Paul Menzel, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57290 )
Change subject: mb/google/brya/variants: fix override values for power limits
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57290/comment/8b58a7d2_1bcc3e77
PS3, Line 8:
Please state the problem, and why TDP needs to be checked.
Done
https://review.coreboot.org/c/coreboot/+/57290/comment/e22068e0_5bf789f1
PS3, Line 9: Fix override values for power limits for 28W and 45W TDP based 682 SKU.
Where do you get the values from?
It's mentioned in patch comment at line number 8 : https://review.coreboot.org/c/coreboot/+/57290/4/src/mainboard/google/brya/v...
These values as per discussion in bug:191906315 comment #10
File src/mainboard/google/brya/variants/brya0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/57290/comment/89d220fd_f7451fba
PS3, Line 7: TDP(Watts)
TDP (Watts)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I796e56321ae9c8312530a4b8986cd73a2245f5fa
Gerrit-Change-Number: 57290
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet Pawnikar
sumeet.r.pawnikar@intel.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 08:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment