Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50273 )
Change subject: soc/amd/cezanne: select ACPI support and make the compiler happy
......................................................................
Patch Set 4:
(2 comments)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/50273/comment/b753d6bd_a9cf3c4d
PS4, Line 19: select HAVE_ACPI_TABLES
Why not make SOC_AMD_COMMON_BLOCK_ACPI select this?
https://review.coreboot.org/c/coreboot/+/50273/comment/e89f9550_e89b027e
PS4, Line 25: select SOC_AMD_COMMON
select SOC_AMD_COMMON_BLOCK_ACPI
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b806569154e46418fa7d4fa35575a0acfec9132
Gerrit-Change-Number: 50273
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 11:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment