Attention is currently required from: V Sowmya, Rizwan Qureshi, Balaji Manigandan, Krishna P Bhat D, Usha P.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62913 )
Change subject: mb/intel/adlrvp: Set half_populated true for ADL-N
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62913/comment/6eab629a_1904c836
PS4, Line 51: #if CONFIG(BOARD_INTEL_ADLRVP_N_EXT_EC) || CONFIG(BOARD_INTEL_ADLRVP_N)
Please use C instead of CPP statements.
https://review.coreboot.org/c/coreboot/+/62913/comment/7bb4450a_4c4e63b7
PS4, Line 51: #if CONFIG(BOARD_INTEL_ADLRVP_N_EXT_EC) || CONFIG(BOARD_INTEL_ADLRVP_N)
: const bool half_populated = true;
: #else
: const bool half_populated = false;
: #endif
Ternary operator can also be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecc3018a1ab039990ba47898ff0e0e2ede695cc
Gerrit-Change-Number: 62913
Gerrit-PatchSet: 4
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 06:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment