Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61301 )
Change subject: mb/system76: Add custom backlight levels for Intel GMA ......................................................................
mb/system76: Add custom backlight levels for Intel GMA
Add custom backlight levels for all models except:
- addw1/addw2: Uses an OLED display - bonw14: Does not use the iGPU
Change-Id: Ibea37f19acca0d718211fc41706019a92a240c70 Signed-off-by: Tim Crawford tcrawford@system76.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/61301 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jeremy Soller jeremy@system76.com --- A src/mainboard/system76/cml-u/acpi/backlight.asl M src/mainboard/system76/cml-u/acpi/mainboard.asl M src/mainboard/system76/cml-u/dsdt.asl A src/mainboard/system76/gaze15/acpi/backlight.asl M src/mainboard/system76/gaze15/acpi/mainboard.asl M src/mainboard/system76/gaze15/dsdt.asl A src/mainboard/system76/kbl-u/acpi/backlight.asl M src/mainboard/system76/kbl-u/acpi/mainboard.asl A src/mainboard/system76/oryp5/acpi/backlight.asl M src/mainboard/system76/oryp5/acpi/mainboard.asl M src/mainboard/system76/oryp5/dsdt.asl A src/mainboard/system76/oryp6/acpi/backlight.asl M src/mainboard/system76/oryp6/acpi/mainboard.asl M src/mainboard/system76/oryp6/dsdt.asl A src/mainboard/system76/tgl-h/acpi/backlight.asl M src/mainboard/system76/tgl-h/acpi/mainboard.asl M src/mainboard/system76/tgl-h/dsdt.asl A src/mainboard/system76/tgl-u/acpi/backlight.asl M src/mainboard/system76/tgl-u/acpi/mainboard.asl M src/mainboard/system76/tgl-u/dsdt.asl A src/mainboard/system76/whl-u/acpi/backlight.asl M src/mainboard/system76/whl-u/acpi/mainboard.asl M src/mainboard/system76/whl-u/dsdt.asl 23 files changed, 291 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved
diff --git a/src/mainboard/system76/cml-u/acpi/backlight.asl b/src/mainboard/system76/cml-u/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/cml-u/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/cml-u/acpi/mainboard.asl b/src/mainboard/system76/cml-u/acpi/mainboard.asl index 416cc5a..3335ba8 100644 --- a/src/mainboard/system76/cml-u/acpi/mainboard.asl +++ b/src/mainboard/system76/cml-u/acpi/mainboard.asl @@ -6,6 +6,9 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } }
Scope (_GPE) { diff --git a/src/mainboard/system76/cml-u/dsdt.asl b/src/mainboard/system76/cml-u/dsdt.asl index 982e226..b633254 100644 --- a/src/mainboard/system76/cml-u/dsdt.asl +++ b/src/mainboard/system76/cml-u/dsdt.asl @@ -19,7 +19,6 @@ { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/cannonlake/acpi/southbridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/gaze15/acpi/backlight.asl b/src/mainboard/system76/gaze15/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/gaze15/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/gaze15/acpi/mainboard.asl b/src/mainboard/system76/gaze15/acpi/mainboard.asl index 4e67439..b235437 100644 --- a/src/mainboard/system76/gaze15/acpi/mainboard.asl +++ b/src/mainboard/system76/gaze15/acpi/mainboard.asl @@ -6,6 +6,9 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } }
Scope (_GPE) { diff --git a/src/mainboard/system76/gaze15/dsdt.asl b/src/mainboard/system76/gaze15/dsdt.asl index d2bd57d..a48382b 100644 --- a/src/mainboard/system76/gaze15/dsdt.asl +++ b/src/mainboard/system76/gaze15/dsdt.asl @@ -18,7 +18,6 @@ Device (_SB.PCI0) { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/cannonlake/acpi/southbridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/kbl-u/acpi/backlight.asl b/src/mainboard/system76/kbl-u/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/kbl-u/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/kbl-u/acpi/mainboard.asl b/src/mainboard/system76/kbl-u/acpi/mainboard.asl index 11735e8..a36923f 100644 --- a/src/mainboard/system76/kbl-u/acpi/mainboard.asl +++ b/src/mainboard/system76/kbl-u/acpi/mainboard.asl @@ -1,6 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */
Scope (_SB) { + Scope (PCI0) { + #include "backlight.asl" + } + #include "ac.asl" #include "battery.asl" #include "buttons.asl" diff --git a/src/mainboard/system76/oryp5/acpi/backlight.asl b/src/mainboard/system76/oryp5/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/oryp5/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/oryp5/acpi/mainboard.asl b/src/mainboard/system76/oryp5/acpi/mainboard.asl index 4373b2a..17d2221 100644 --- a/src/mainboard/system76/oryp5/acpi/mainboard.asl +++ b/src/mainboard/system76/oryp5/acpi/mainboard.asl @@ -7,6 +7,9 @@ Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } }
Scope (_GPE) diff --git a/src/mainboard/system76/oryp5/dsdt.asl b/src/mainboard/system76/oryp5/dsdt.asl index 982e226..b633254 100644 --- a/src/mainboard/system76/oryp5/dsdt.asl +++ b/src/mainboard/system76/oryp5/dsdt.asl @@ -19,7 +19,6 @@ { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/cannonlake/acpi/southbridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/oryp6/acpi/backlight.asl b/src/mainboard/system76/oryp6/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/oryp6/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/oryp6/acpi/mainboard.asl b/src/mainboard/system76/oryp6/acpi/mainboard.asl index 4e67439..b235437 100644 --- a/src/mainboard/system76/oryp6/acpi/mainboard.asl +++ b/src/mainboard/system76/oryp6/acpi/mainboard.asl @@ -6,6 +6,9 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } }
Scope (_GPE) { diff --git a/src/mainboard/system76/oryp6/dsdt.asl b/src/mainboard/system76/oryp6/dsdt.asl index d2bd57d..a48382b 100644 --- a/src/mainboard/system76/oryp6/dsdt.asl +++ b/src/mainboard/system76/oryp6/dsdt.asl @@ -18,7 +18,6 @@ Device (_SB.PCI0) { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/cannonlake/acpi/southbridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/tgl-h/acpi/backlight.asl b/src/mainboard/system76/tgl-h/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/tgl-h/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/tgl-h/acpi/mainboard.asl b/src/mainboard/system76/tgl-h/acpi/mainboard.asl index 4675bc9..c982a9e 100644 --- a/src/mainboard/system76/tgl-h/acpi/mainboard.asl +++ b/src/mainboard/system76/tgl-h/acpi/mainboard.asl @@ -6,4 +6,7 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } } diff --git a/src/mainboard/system76/tgl-h/dsdt.asl b/src/mainboard/system76/tgl-h/dsdt.asl index fb40a5d..904073c 100644 --- a/src/mainboard/system76/tgl-h/dsdt.asl +++ b/src/mainboard/system76/tgl-h/dsdt.asl @@ -20,7 +20,6 @@ #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/tigerlake/acpi/southbridge.asl> #include <soc/intel/tigerlake/acpi/tcss.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/tgl-u/acpi/backlight.asl b/src/mainboard/system76/tgl-u/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/tgl-u/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/tgl-u/acpi/mainboard.asl b/src/mainboard/system76/tgl-u/acpi/mainboard.asl index 4675bc9..c982a9e 100644 --- a/src/mainboard/system76/tgl-u/acpi/mainboard.asl +++ b/src/mainboard/system76/tgl-u/acpi/mainboard.asl @@ -6,4 +6,7 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } } diff --git a/src/mainboard/system76/tgl-u/dsdt.asl b/src/mainboard/system76/tgl-u/dsdt.asl index fb40a5d..904073c 100644 --- a/src/mainboard/system76/tgl-u/dsdt.asl +++ b/src/mainboard/system76/tgl-u/dsdt.asl @@ -20,7 +20,6 @@ #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/tigerlake/acpi/southbridge.asl> #include <soc/intel/tigerlake/acpi/tcss.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl> diff --git a/src/mainboard/system76/whl-u/acpi/backlight.asl b/src/mainboard/system76/whl-u/acpi/backlight.asl new file mode 100644 index 0000000..f020234 --- /dev/null +++ b/src/mainboard/system76/whl-u/acpi/backlight.asl @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <drivers/intel/gma/acpi/gma.asl> + +Scope (GFX0) +{ + Name (BRIG, Package (22) { + 40, /* default AC */ + 40, /* default Battery */ + 5, + 10, + 15, + 20, + 25, + 30, + 35, + 40, + 45, + 50, + 55, + 60, + 65, + 70, + 75, + 80, + 85, + 90, + 95, + 100 + }) +} diff --git a/src/mainboard/system76/whl-u/acpi/mainboard.asl b/src/mainboard/system76/whl-u/acpi/mainboard.asl index ade0bb2..2495377 100644 --- a/src/mainboard/system76/whl-u/acpi/mainboard.asl +++ b/src/mainboard/system76/whl-u/acpi/mainboard.asl @@ -6,6 +6,9 @@
Scope (_SB) { #include "sleep.asl" + Scope (PCI0) { + #include "backlight.asl" + } }
Scope (_GPE) { diff --git a/src/mainboard/system76/whl-u/dsdt.asl b/src/mainboard/system76/whl-u/dsdt.asl index 982e226..b633254 100644 --- a/src/mainboard/system76/whl-u/dsdt.asl +++ b/src/mainboard/system76/whl-u/dsdt.asl @@ -19,7 +19,6 @@ { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/cannonlake/acpi/southbridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
#include <southbridge/intel/common/acpi/sleepstates.asl>
-
Felix Held (Code Review)