build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 )
Change subject: [WIP]mb/opencellular/satima: Add new port ......................................................................
Patch Set 15:
(174 comments)
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... File src/mainboard/opencellular/satima/cn81xx-linux.dtsi:
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/c... PS15, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/d... File src/mainboard/opencellular/satima/death.c:
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/d... PS15, Line 31: } while(1); space required before the open parenthesis '('
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/m... File src/mainboard/opencellular/satima/mainboard.h:
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/m... PS15, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... File src/mainboard/opencellular/satima/sff8104-linux.dts:
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt
https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/s... PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/
-
build bot (Jenkins) (Code Review)