Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36553 )
Change subject: soc/intel/tigerlake/acpi: Copy acpi directory from icelake
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36553/2/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/36553/2/src/soc/intel/tigerlake/acp...
PS2, Line 226:
: Name (EP_B, 0) /* to store EP BAR */
: Name (MH_B, 0) /* to store MCH BAR */
: Name (PC_B, 0) /* to store PCIe BAR */
: Name (PC_L, 0) /* to store PCIe BAR Length */
: Name (DM_B, 0) /* to store DMI BAR
let me take that AR to fix this soon from tgl
Could you add a FIXME/TODO comment?
https://review.coreboot.org/c/coreboot/+/36553/6/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/36553/6/src/soc/intel/tigerlake/acp...
PS6, Line 197: ^
unneeded.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If967cb5904f543ce21eb6e89421df0e5673d2238
Gerrit-Change-Number: 36553
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Nov 2019 11:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment