Attention is currently required from: Angel Pons, Federico Amedeo Izzo.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add AOOSTAR R1 (WTR_R1) ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/aoostar/wtr_r1/gpio.h:
https://review.coreboot.org/c/coreboot/+/82010/comment/93ab69bd_134955b5 : PS10, Line 14: _PAD_CFG_STRUCT(GPP_B0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | : PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(IGNORE)), /* CORE_VID0 */ Would be great if these could be translated to more readable macros, like
``` PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* CORE_VID0 */ ```
However, that can be done in a separate change. Let's keep it as it is for now.